From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jason Wang <jasowang@redhat.com>
Cc: wangyunjian <wangyunjian@huawei.com>,
Network Development <netdev@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
virtualization@lists.linux-foundation.org,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
chenchanghu <chenchanghu@huawei.com>,
xudingke <xudingke@huawei.com>,
"huangbin (J)" <brian.huangbin@huawei.com>
Subject: Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails
Date: Fri, 15 Jan 2021 13:15:30 -0500 [thread overview]
Message-ID: <CA+FuTSdvhJ9An9F5pZHKzEKx1NWFArY=QE0C1RB2+nOVP6iNyw@mail.gmail.com> (raw)
In-Reply-To: <ff01b9da-f2a7-3559-63cc-833f52280ef6@redhat.com>
On Fri, Jan 15, 2021 at 1:12 AM Jason Wang <jasowang@redhat.com> wrote:
>
>
> On 2021/1/15 下午12:46, wangyunjian wrote:
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > Currently the driver doesn't drop a packet which can't be sent by tun
> > (e.g bad packet). In this case, the driver will always process the
> > same packet lead to the tx queue stuck.
> >
> > To fix this issue:
> > 1. in the case of persistent failure (e.g bad packet), the driver
> > can skip this descriptor by ignoring the error.
> > 2. in the case of transient failure (e.g -ENOBUFS, -EAGAIN and -ENOMEM),
> > the driver schedules the worker to try again.
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
>
> Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2021-01-15 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 4:46 [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails wangyunjian
2021-01-15 6:05 ` Jason Wang
2021-01-15 18:15 ` Willem de Bruijn [this message]
2021-01-18 22:33 ` Jakub Kicinski
2021-01-19 9:56 ` Michael S. Tsirkin
2021-01-19 19:14 ` Jakub Kicinski
2021-01-19 9:55 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSdvhJ9An9F5pZHKzEKx1NWFArY=QE0C1RB2+nOVP6iNyw@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=brian.huangbin@huawei.com \
--cc=chenchanghu@huawei.com \
--cc=jasowang@redhat.com \
--cc=jerry.lilijun@huawei.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).