From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Network Development <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Alexander Lobakin <alobakin@pm.me>
Subject: Re: [PATCH net-next v3 4/8] udp: never accept GSO_FRAGLIST packets
Date: Tue, 30 Mar 2021 11:14:01 -0400 [thread overview]
Message-ID: <CA+FuTSe9q2+PiGvUnyNSs48CjzABotNn1CE8V0VXKFwuhBhMOQ@mail.gmail.com> (raw)
In-Reply-To: <4dc90e5bc0f6d7152e6b6dcde4bb409fd4c6d2ea.1617099959.git.pabeni@redhat.com>
On Tue, Mar 30, 2021 at 6:30 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> Currently the UDP protocol delivers GSO_FRAGLIST packets to
> the sockets without the expected segmentation.
>
> This change addresses the issue introducing and maintaining
> a couple of new fields to explicitly accept SKB_GSO_UDP_L4
> or GSO_FRAGLIST packets. Additionally updates udp_unexpected_gso()
> accordingly.
>
> UDP sockets enabling UDP_GRO stil keep accept_udp_fraglist
> zeroed.
>
> v1 -> v2:
> - use 2 bits instead of a whole GSO bitmask (Willem)
>
> Fixes: 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2021-03-30 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 10:28 [PATCH net-next v3 0/8] udp: GRO L4 improvements Paolo Abeni
2021-03-30 10:28 ` [PATCH net-next v3 1/8] udp: fixup csum for GSO receive slow path Paolo Abeni
2021-03-30 15:15 ` Willem de Bruijn
2021-03-30 10:28 ` [PATCH net-next v3 2/8] udp: skip L4 aggregation for UDP tunnel packets Paolo Abeni
2021-03-30 10:28 ` [PATCH net-next v3 3/8] udp: properly complete L4 GRO over UDP tunnel packet Paolo Abeni
2021-03-30 10:28 ` [PATCH net-next v3 4/8] udp: never accept GSO_FRAGLIST packets Paolo Abeni
2021-03-30 15:14 ` Willem de Bruijn [this message]
2021-03-30 10:28 ` [PATCH net-next v3 5/8] vxlan: allow L4 GRO passthrough Paolo Abeni
2021-03-30 15:14 ` Willem de Bruijn
2021-03-30 10:28 ` [PATCH net-next v3 6/8] geneve: allow UDP L4 GRO passthrou Paolo Abeni
2021-03-30 10:28 ` [PATCH net-next v3 7/8] bareudp: " Paolo Abeni
2021-03-30 10:28 ` [PATCH net-next v3 8/8] selftests: net: add UDP GRO forwarding self-tests Paolo Abeni
2021-03-30 15:49 ` Willem de Bruijn
2021-03-31 0:20 ` [PATCH net-next v3 0/8] udp: GRO L4 improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSe9q2+PiGvUnyNSs48CjzABotNn1CE8V0VXKFwuhBhMOQ@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=alobakin@pm.me \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).