From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75622C43381 for ; Fri, 15 Feb 2019 16:59:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C28C20823 for ; Fri, 15 Feb 2019 16:59:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GKTBwAZn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729928AbfBOQ7P (ORCPT ); Fri, 15 Feb 2019 11:59:15 -0500 Received: from mail-yb1-f196.google.com ([209.85.219.196]:41554 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726122AbfBOQ7P (ORCPT ); Fri, 15 Feb 2019 11:59:15 -0500 Received: by mail-yb1-f196.google.com with SMTP id 18so2422839ybf.8 for ; Fri, 15 Feb 2019 08:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NwcWmRWKGiY5MbxawikKpwvAC45s8K/bN+AFJwT+7Qo=; b=GKTBwAZn9Ahnsm8AtBekFzRSY19NBj3jnmBlepvxH6c0brx+iUUa1YQqDoUiyrTBHa zSNB9gmWbzOFL2OzGXZhp23BWG3kgPIMnn9nONkVwtgwzZ1Avpy4uEY5/s3lCzv9UqYt IWOJTVtWUbjceQMWhYSUr6Ube7yx2XmftsKcXrVbkKg2MRsvOhtHL5uavTTHcAsPuJXR dJ2B5Yi/5EeWzQ9303N6EIM26KD2/5OdUW0b2PnTQJjiJVQG1H3FbVmFIll7tB6N7nMX HkDHVSZeam1tzR6U1qDok7i6NzlcLyLmHHuRMLRk5mvyyoq9c+7ddOHFfukTuc01wXwV ykag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NwcWmRWKGiY5MbxawikKpwvAC45s8K/bN+AFJwT+7Qo=; b=qHEw4Vm3C3SuFt7syQY3UNoa2Y/wOgYXP6n3GjIHgK255IST1kLbWXMeo0Ii7l8MRe aL6C12Gp2guW2ehe0G7tAaBPwLAiJO1qNbzN8QJgB5uxYJ79EDzw07X3NKqcjJFAhcl3 7KpVHOqKG8S+slCH5MBIb0wMOhDmtVw2TCeYYT9vP7Hx2m+1GwriGqqSnCdhGP3QLW6Z 0FhBBan7Y601fi7vcwDfj1ZQGNQt9IuAC+5cjnWd2wo0eVsfsSDEbFJWwPK+iLv8Kvxn 8XNLkEBZI2tNnPmesWTm3VBuRNIA6LVMrPhoShcELSxkCARgtRIWqTzDPydcTaXai7C5 Vt1Q== X-Gm-Message-State: AHQUAuahqjylnb8rM4WNfnLXrV0w2UYu7tpfHgqZ3hvDi2dQxoAZtncl 9HjDNS2CcZfr268PLeSN7u0yqMb6 X-Google-Smtp-Source: AHgI3IZDiiQvj+3Qwbwz4kuY3bD/xvj6FAxNlloIAq33s2N6uGysOvEok0qzVkf6sEYVYqyGxHvGVQ== X-Received: by 2002:a25:e82:: with SMTP id 124mr8754303ybo.70.1550249953810; Fri, 15 Feb 2019 08:59:13 -0800 (PST) Received: from mail-yw1-f47.google.com (mail-yw1-f47.google.com. [209.85.161.47]) by smtp.gmail.com with ESMTPSA id r124sm2027317ywb.39.2019.02.15.08.59.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 08:59:12 -0800 (PST) Received: by mail-yw1-f47.google.com with SMTP id u200so3934542ywu.10 for ; Fri, 15 Feb 2019 08:59:12 -0800 (PST) X-Received: by 2002:a81:a00f:: with SMTP id x15mr8766959ywg.163.1550249951798; Fri, 15 Feb 2019 08:59:11 -0800 (PST) MIME-Version: 1.0 References: <1550249574-26772-1-git-send-email-alexey.kodanev@oracle.com> In-Reply-To: <1550249574-26772-1-git-send-email-alexey.kodanev@oracle.com> From: Willem de Bruijn Date: Fri, 15 Feb 2019 11:58:35 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net] sock: return uapi errno in sock_setsockopt() for SO_ZEROCOPY To: Alexey Kodanev Cc: Network Development , Petr Vorel , David Miller Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 15, 2019 at 11:51 AM Alexey Kodanev wrote: > > For unsupported protocols, setsockopt() with SO_ZEROCOPY > option sets errno to ENOTSUPP(524). But this number is > not defined anywhere in the include/uapi/ headers. > > To make sure userspace sees the known number, replace > ENOTSUPP(524) with EOPNOTSUPP(95). > > Fixes: 76851d1212c1 ("sock: add SOCK_ZEROCOPY sockopt") > Signed-off-by: Alexey Kodanev > Reported-by: Petr Vorel This code has been there since 4.14. I think it's too late to change system call behavior.