From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: kernelnewbies@kernelnewbies.org,
Network Development <netdev@vger.kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Sitnicki <jakub@cloudflare.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: UDP implementation and the MSG_MORE flag
Date: Tue, 26 Jan 2021 16:54:55 -0500 [thread overview]
Message-ID: <CA+FuTSez-w-Y6LfXxEcqbB5QucPRfCEFmCd5a4LtOGcyOjGOug@mail.gmail.com> (raw)
In-Reply-To: <20210126141248.GA27281@optiplex>
On Tue, Jan 26, 2021 at 9:58 AM Oliver Graute <oliver.graute@gmail.com> wrote:
>
> Hello,
>
> we observe some unexpected behavior in the UDP implementation of the
> linux kernel.
>
> Some UDP packets send via the loopback interface are dropped in the
> kernel on the receive side when using sendto with the MSG_MORE flag.
> Every drop increases the InCsumErrors in /proc/self/net/snmp. Some
> example code to reproduce it is appended below.
>
> In the code we tracked it down to this code section. ( Even a little
> further but its unclear to me wy the csum() is wrong in the bad case)
>
> udpv6_recvmsg()
> ...
> if (checksum_valid || udp_skb_csum_unnecessary(skb)) {
> if (udp_skb_is_linear(skb))
> err = copy_linear_skb(skb, copied, off, &msg->msg_iter);
> else
> err = skb_copy_datagram_msg(skb, off, msg, copied);
> } else {
> err = skb_copy_and_csum_datagram_msg(skb, off, msg);
> if (err == -EINVAL) {
> goto csum_copy_err;
> }
> }
> ...
>
Thanks for the report with a full reproducer.
I don't have a full answer yet, but can reproduce this easily.
The third program, without MSG_MORE, builds an skb with
CHECKSUM_PARTIAL in __ip_append_data. When looped to the receive path
that ip_summed means no additional validation is needed. As encoded in
skb_csum_unnecessary.
The first and second programs are essentially the same, bar for a
slight difference in length. In both cases packet length is very short
compared to the loopback device MTU. Because of MSG_MORE, these
packets have CHECKSUM_NONE.
On receive in
__udp4_lib_rcv()
udp4_csum_init()
err = skb_checksum_init_zero_check()
The second program validates and sets ip_summed = CHECKSUM_COMPLETE
and csum_valid = 1.
The first does not, though err == 0.
This appears to succeed consistently for packets <= 68B of payload,
fail consistently otherwise. It is not clear to me yet what causes
this distinction.
next prev parent reply other threads:[~2021-01-26 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 14:12 UDP implementation and the MSG_MORE flag Oliver Graute
2021-01-26 21:54 ` Willem de Bruijn [this message]
2021-01-26 22:00 ` Willem de Bruijn
2021-01-27 3:25 ` Willem de Bruijn
2021-01-28 2:53 ` Willem de Bruijn
2021-01-28 3:10 ` Willem de Bruijn
2021-01-28 15:23 ` Oliver Graute
2021-02-03 22:21 ` michi1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSez-w-Y6LfXxEcqbB5QucPRfCEFmCd5a4LtOGcyOjGOug@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=jakub@cloudflare.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).