From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8205BC433DF for ; Wed, 5 Aug 2020 09:34:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5704A2075A for ; Wed, 5 Aug 2020 09:34:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oenfg43n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728330AbgHEJeV (ORCPT ); Wed, 5 Aug 2020 05:34:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728135AbgHEJdv (ORCPT ); Wed, 5 Aug 2020 05:33:51 -0400 Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B682C06179E for ; Wed, 5 Aug 2020 02:33:51 -0700 (PDT) Received: by mail-ua1-x941.google.com with SMTP id q68so10626062uaq.0 for ; Wed, 05 Aug 2020 02:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zv3njctJm6+JcXZYqCty4/Sd4dBn0kL3k7iTzjdDtfw=; b=oenfg43n0bbPqzDbC7M2gy1BFz6L4j5HVCwHLtU/Pd/u1lL9Q8XQe9N2tV7UufJLBo MATyUl4G6KT941Gq5GWK1IRQAUrFB+lObmZPz6DsWSFZIk98PEkOpyS44op89AjF0Yhc /nCPtftT2HFYYw1+IL9n60Qm0Rse1uvZQdFsSt1qycaGxhSvOLb2GrZKd3IQdGpnbER7 55M2mlDFMUTcf3/1WW8TpGa8ffoPYhK6NHu8G+w75fYXZQNHZYmxpY7ENGI8aJd1IqbQ COcN6TjLK7eeGurWWCYgSthmkkpR2GYKwx/B6sEXmj3k30YgV+xNiFNNEZmqWstxYnmp HSoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zv3njctJm6+JcXZYqCty4/Sd4dBn0kL3k7iTzjdDtfw=; b=LtW3MCDiTIu5M/Z5FdQRxMXTppB8hBegLpkNleoAdvv9XChZMMO5SRUjbcO0irYXW/ 3Vdm3HIipfk4JirMc8IAozc3Vsn3qKMQ5gcK8Q0YVQNw83a6Z050dNXGFlFe5OpQ+TM4 3oAMX/k2cXj/3rHO9qVWNy0x+7FzKTyCq9qTRmP8C1zcaO3PcqoECwqzmR19uutOps3r MPOCgm6zMU6qX/NIdzL9sB6LJ9/bB5jU3BiWcgwKmwXL34UKFfyV2KUYndE/d4uzI+ML wXv6K2ly1wzbEx0Qyy9RQbg1qfTSCaYzGhvpM+i/II9z1H2fqZjPMbkioCC3CvVp6uRN O5gw== X-Gm-Message-State: AOAM532kws/PDrb6Y6dOJZzE73bGwnfdX0rZu/wX9iMP/1jQdHc4x9g/ 5vwiJpvsENL0ZbYl6ClOEXcDJLEs4mw= X-Google-Smtp-Source: ABdhPJxuClENbG9opTponTHOKYiGVCepKraQsC/pUZxsLUxMtUH4K0ii7TK9ir9VFN824AITyxx1Uw== X-Received: by 2002:ab0:37d3:: with SMTP id e19mr1335947uav.64.1596620029728; Wed, 05 Aug 2020 02:33:49 -0700 (PDT) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com. [209.85.217.43]) by smtp.gmail.com with ESMTPSA id p192sm241943vsd.23.2020.08.05.02.33.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 02:33:48 -0700 (PDT) Received: by mail-vs1-f43.google.com with SMTP id i129so4921445vsi.3 for ; Wed, 05 Aug 2020 02:33:48 -0700 (PDT) X-Received: by 2002:a05:6102:517:: with SMTP id l23mr1162285vsa.114.1596620027960; Wed, 05 Aug 2020 02:33:47 -0700 (PDT) MIME-Version: 1.0 References: <20200802195046.402539-1-xie.he.0141@gmail.com> <9975370f14b8ddeafc8dec7bc6c0878a@dev.tdt.de> In-Reply-To: From: Willem de Bruijn Date: Wed, 5 Aug 2020 11:33:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [net v3] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len To: Xie He Cc: Martin Schiller , "David S. Miller" , Jakub Kicinski , Linux Kernel Network Developers , LKML , Linux X25 , Willem de Bruijn , Brian Norris , netdev-owner@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 5, 2020 at 10:57 AM Xie He wrote: > > On Tue, Aug 4, 2020 at 10:23 PM Martin Schiller wrote: > > > > > Adding skb_cow before these skb_push calls would indeed help > > > preventing kernel panics, but that might not be the essential issue > > > here, and it might also prevent us from discovering the real issue. (I > > > guess this is also the reason skb_cow is not included in skb_push > > > itself.) > > > > Well, you are right that the panic is "useful" to discover the real > > problem. But on the other hand, if it is possible to prevent a panic, I > > think we should do so. Maybe with adding a warning, when skb_cow() needs > > to reallocate memory. > > > > But this is getting a little bit off topic. For this patch I can say: > > > > LGTM. > > > > Reviewed-by: Martin Schiller > > Thank you so much! > > Yes, it might be better to use skb_cow with a warning so that we can > prevent kernel panic while still being able to discover the problem. Let's not add defenses to work around possibly buggy code. In the long run that reduces code quality. Instead, fix bugs at the source.