From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: yang_y_yi@163.com
Cc: Network Development <netdev@vger.kernel.org>,
u9012063@gmail.com, yangyi01@inspur.com
Subject: Re: [PATCH net-next] net/packet: fix TPACKET_V3 performance issue in case of TSO
Date: Wed, 25 Mar 2020 10:37:59 -0400 [thread overview]
Message-ID: <CA+FuTSf5U_ndpmBisjqLMihx0q+wCrqndDAUT1vF3=1DXJnumw@mail.gmail.com> (raw)
In-Reply-To: <20200325140845.11840-1-yang_y_yi@163.com>
On Wed, Mar 25, 2020 at 10:10 AM <yang_y_yi@163.com> wrote:
>
> From: Yi Yang <yangyi01@inspur.com>
>
> TPACKET_V3 performance is very very bad in case of TSO, it is even
> worse than non-TSO case. For Linux kernels which set CONFIG_HZ to
> 1000, req.tp_retire_blk_tov = 1 can help improve it a bit, but some
> Linux distributions set CONFIG_HZ to 250, so req.tp_retire_blk_tov = 1
> actually means req.tp_retire_blk_tov = 4, it won't have any help.
>
> This fix patch can fix the aforementioned performance issue, it can
> boost the performance from 3.05Gbps to 16.9Gbps, a very huge
> improvement. It will retire current block as early as possible in
> case of TSO in order that userspace application can consume it
> in time.
>
> Signed-off-by: Yi Yang <yangyi01@inspur.com>
I'm not convinced that special casing TSO packets is the right solution here.
We should consider converting TPACKET_V3 to hrtimer and allow usec
resolution block timer.
Would that solve your issue?
next prev parent reply other threads:[~2020-03-25 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 14:08 [PATCH net-next] net/packet: fix TPACKET_V3 performance issue in case of TSO yang_y_yi
2020-03-25 14:37 ` Willem de Bruijn [this message]
2020-03-26 0:43 ` 答复: [vger.kernel.org代发]Re: " Yi Yang (杨燚)-云服务集团
2020-03-26 1:20 ` Willem de Bruijn
2020-03-27 2:33 ` 答复: [vger.kernel.org代发]Re: [vger.kernel.org代发]Re: [PATCH net-next] net/ packet: " Yi Yang (杨燚)-云服务集团
2020-03-27 3:16 ` Willem de Bruijn
2020-03-28 8:36 ` 答复: " Yi Yang (杨燚)-云服务集团
2020-03-28 18:36 ` Willem de Bruijn
2020-03-29 2:42 ` 答复: " Yi Yang (杨�D)-云服务集团
2020-03-30 1:51 ` Willem de Bruijn
2020-03-30 6:34 ` 答复: " Yi Yang (杨燚)-云服务集团
2020-03-30 14:16 ` Willem de Bruijn
2020-04-14 3:41 ` 答复: [vger.kernel.org代发]Re: [vger.kernel.org代发]Re: [vger.kernel.org代 发]Re: [PATCH net-next] net/ packet: fix TPACKET_V3 perform ance " Yi Yang (杨燚)-云服务集团
2020-04-14 14:03 ` Willem de Bruijn
2020-04-15 3:33 ` 答复: [vger.kernel.org代发]Re: [vger.kernel.org代发]Re: [vger.kernel.org代 发]Re: [vger.kernel.org代 发]Re: [PATCH net-next] net/ pa cket: " Yi Yang (杨燚)-云服务集团
[not found] ` <8c7c4b8.a0a4.17112280afb.Coremail.yang_y_yi@163.com>
2020-03-26 1:16 ` Re: [PATCH net-next] net/packet: fix TPACKET_V3 performance " Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSf5U_ndpmBisjqLMihx0q+wCrqndDAUT1vF3=1DXJnumw@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
--cc=yang_y_yi@163.com \
--cc=yangyi01@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).