From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: David Wilder <dwilder@us.ibm.com>
Cc: Network Development <netdev@vger.kernel.org>,
tlfalcon@linux.ibm.com, cris.forno@ibm.com,
pradeeps@linux.vnet.ibm.com, wilder@us.ibm.com,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [ PATCH v2 2/2] ibmveth: Identify ingress large send packets.
Date: Wed, 14 Oct 2020 12:23:31 -0400 [thread overview]
Message-ID: <CA+FuTSfRXhJWOerKL=4OV=ku6v3XfqhBhV0=rtiAfaPgr=yq4w@mail.gmail.com> (raw)
In-Reply-To: <20201013232014.26044-3-dwilder@us.ibm.com>
On Tue, Oct 13, 2020 at 7:21 PM David Wilder <dwilder@us.ibm.com> wrote:
>
> Ingress large send packets are identified by either:
> The IBMVETH_RXQ_LRG_PKT flag in the receive buffer
> or with a -1 placed in the ip header checksum.
> The method used depends on firmware version. Frame
> geometry and sufficient header validation is performed by the
> hypervisor eliminating the need for further header checks here.
>
> Fixes: 7b5967389f5a ("ibmveth: set correct gso_size and gso_type")
> Signed-off-by: David Wilder <dwilder@us.ibm.com>
> Reviewed-by: Thomas Falcon <tlfalcon@linux.ibm.com>
> Reviewed-by: Cristobal Forno <cris.forno@ibm.com>
> Reviewed-by: Pradeep Satyanarayana <pradeeps@linux.vnet.ibm.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Thanks for clarifying the header validation. I clearly had missed that :)
next prev parent reply other threads:[~2020-10-14 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 23:20 [ PATCH v2 0/2] ibmveth gso fix David Wilder
2020-10-13 23:20 ` [ PATCH v2 1/2] ibmveth: Switch order of ibmveth_helper calls David Wilder
2020-10-14 16:22 ` Willem de Bruijn
2020-10-15 3:23 ` Jakub Kicinski
2020-10-13 23:20 ` [ PATCH v2 2/2] ibmveth: Identify ingress large send packets David Wilder
2020-10-14 16:23 ` Willem de Bruijn [this message]
2020-10-15 3:23 ` [ PATCH v2 0/2] ibmveth gso fix Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSfRXhJWOerKL=4OV=ku6v3XfqhBhV0=rtiAfaPgr=yq4w@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=cris.forno@ibm.com \
--cc=dwilder@us.ibm.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pradeeps@linux.vnet.ibm.com \
--cc=tlfalcon@linux.ibm.com \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).