From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A6CCC25B04 for ; Wed, 14 Dec 2022 12:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238420AbiLNMEy (ORCPT ); Wed, 14 Dec 2022 07:04:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238347AbiLNME1 (ORCPT ); Wed, 14 Dec 2022 07:04:27 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A14C127DC2 for ; Wed, 14 Dec 2022 04:02:54 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id 124so4317418pfy.0 for ; Wed, 14 Dec 2022 04:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura.hr; s=sartura; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=peaw+2jBoexT/V/OL/klaMSfRkpK0w1QubB8hlHtjKU=; b=IffZpvmos6IFA8F2Mu7UX03vFoZdzSvAl4wArexI2TJ+mCg8LYPObJ0caqqBk6KELc 7e96IX0TGhm3EbfxrnJUHspRY4C5kzZjXA8RPZhE2bOdCe6tjVnt+Z3CF0kf/nY0nL+5 zhLxH/gVF/oPszrMxuCbjkfNqT6s3OZYE50HYnrLZ7oMjvbFnJ2FU0kVIkcZhH46wiwl wLPAdUYt+VKJPhUoSBgt566qcUxTJYhAUxZrXrKHxPKFY8264tYoNHL+XtQdD6DjNdwK dtgAPPBovln+d78d738YPXAKKoU4rCSJQNQzmoESEN0DTVhkyEgeq7ajtPDj3m1qgn+h UaHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=peaw+2jBoexT/V/OL/klaMSfRkpK0w1QubB8hlHtjKU=; b=bdMgpyjwcUf1iPc1dFUwlm31U8fdKc5jFsHGwWqc+E7uG8j0poaTLsIzOktKUjH29Z l4J0ThBaXgEJgT01o8ihiq+R3+yrcW0p7yBeHusJ2u6kvFjR0MGmWjjHweyblvG8eLEu paKDRbF1z9Z9KOpfAVjZSFC2Pcssl3EdfZ0igFyF9O5uJI0IomTrYFeCSFATKSicd5ln HbUhhXwAVRa0gr6UDvoaRF8KxzLS7m42566aMc6AIoF9KoMzh6gyYC0OkuBqjSFHoD4M XZKo0mox+sdzF0yR4e/sDsiYE+gS1usVhc4SGz8oPBepQIkn0UoqMIuiDRMTIYS3+lV5 ps6g== X-Gm-Message-State: ANoB5pmErRPcfelcHve2hO+rVV+oVu0rO/oJpiMPQRDJ4fIsLguTdNG5 sWWziyn6zdiNyYGPN83wea4Xc3jZRuZ0kcA5MCft1g== X-Google-Smtp-Source: AA0mqf6ACT1hXHaNkKcTvIqqDuxXiD+Qw3prO4hyGi38uOl9IwijS+lvf8GiQLNL3EwGrPbufcxLrNNbvCYdwt6fqnk= X-Received: by 2002:a62:8409:0:b0:575:1168:a970 with SMTP id k9-20020a628409000000b005751168a970mr54638196pfd.54.1671019373770; Wed, 14 Dec 2022 04:02:53 -0800 (PST) MIME-Version: 1.0 References: <20221105194943.826847-1-robimarko@gmail.com> <20221105194943.826847-2-robimarko@gmail.com> <20221107174727.GA7535@thinkpad> <87cz9xcqbd.fsf@kernel.org> <877czn8c2n.fsf@kernel.org> In-Reply-To: <877czn8c2n.fsf@kernel.org> From: Robert Marko Date: Wed, 14 Dec 2022 13:02:42 +0100 Message-ID: Subject: Re: [PATCH 2/2] wifi: ath11k: use unique QRTR instance ID To: Kalle Valo Cc: Manivannan Sadhasivam , Robert Marko , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, elder@linaro.org, hemantk@codeaurora.org, quic_jhugo@quicinc.com, quic_qianyu@quicinc.com, bbhatt@codeaurora.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ansuelsmth@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 22, 2022 at 12:26 PM Kalle Valo wrote: > > Kalle Valo writes: > > > Manivannan Sadhasivam writes: > > > >> On Sat, Nov 05, 2022 at 08:49:43PM +0100, Robert Marko wrote: > >>> Currently, trying to use AHB + PCI/MHI cards or multiple PCI/MHI cards > >>> will cause a clash in the QRTR instance node ID and prevent the driver > >>> from talking via QMI to the card and thus initializing it with: > >>> [ 9.836329] ath11k c000000.wifi: host capability request failed: 1 90 > >>> [ 9.842047] ath11k c000000.wifi: failed to send qmi host cap: -22 > >>> > >> > >> There is still an outstanding issue where you cannot connect two WLAN modules > >> with same node id. > >> > >>> So, in order to allow for this combination of cards, especially AHB + PCI > >>> cards like IPQ8074 + QCN9074 (Used by me and tested on) set the desired > >>> QRTR instance ID offset by calculating a unique one based on PCI domain > >>> and bus ID-s and writing it to bits 7-0 of BHI_ERRDBG2 MHI register by > >>> using the SBL state callback that is added as part of the series. > >>> We also have to make sure that new QRTR offset is added on top of the > >>> default QRTR instance ID-s that are currently used in the driver. > >>> > >> > >> Register BHI_ERRDBG2 is listed as Read only from Host as per the BHI spec. > >> So I'm not sure if this solution is going to work on all ath11k supported > >> chipsets. > >> > >> Kalle, can you confirm? > > > > I can't look at this in detail right now, but hopefully in few days. > > I'll get back to you. > > The solution we have been thinking internally would not use > MHI_CB_EE_SBL_MODE at all, it's not clear for me yet why the mode was > not needed in our solution. Maybe there are firmware modifications? I > think it's best that we submit our proposal as well, then we can then > compare implementations and see what is the best course of action. Kalle, any ETA when you will post your idea? I am constantly hitting this crazy limitation and my idea does not work on cards like QCA6390 so it's not a viable workaround at all. Regards, Robert > > But it looks that not all ath11k hardware and firmware releases support > this feature, we would need meta data information from the firmware to > detect it. I am working on adding firmware meta data support[1] to > ath11k, will post patches for that "soon". > > [1] similar to firmware-N.bin support ath10k has > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches > > -- > ath11k mailing list > ath11k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath11k -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr