From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22228C54EAA for ; Mon, 23 Jan 2023 19:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232029AbjAWTVX (ORCPT ); Mon, 23 Jan 2023 14:21:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231868AbjAWTVW (ORCPT ); Mon, 23 Jan 2023 14:21:22 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AB6D12597 for ; Mon, 23 Jan 2023 11:21:20 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id 36so9742262pgp.10 for ; Mon, 23 Jan 2023 11:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura.hr; s=sartura; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WDXuP5MYYXAbh/GyrwzOk8WyuxyPQCqxZw3q4s3iD6c=; b=tkgcEhOicbtfDwCpvIXKnd8G/FRlL5uYYpKH27sdSg0dZinBGyNI6cfbqXcMQ0INuI C1vXl3B5WfROQHaBB0ZgIO3DsbL8TTj4olwIR8Ff8qa9Mwt6nTxLZAT5FaJB+xs56xnK kVn6WRm+zPNaXAoPyvmPoZJesLk00cfksfuo5LjkfIVGYLZXHeQDXVgDWba83T0JDL9f paDtjpJa/3TzNyFo77rj/ulC4nTXdGJQ6eubkNb35Z8FDePEJYd6WRLBU0HwgDwNbOgu HaDZQhhPOShpXz4hg0RNu6HNR4i95FnsPr2qF0ogzCM5h0eEPZ1xul/uaFP/kdBaUX5+ YTXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WDXuP5MYYXAbh/GyrwzOk8WyuxyPQCqxZw3q4s3iD6c=; b=hwP8Uu7WFrrflkHpqR0kKKN+gv296jBuJhzxzJMeQPfAzv489bKkYf+IGt36EquTHf 3MN86YcCKymqQbYS6Thml0D7Xz2yz5XjsWmloqcczyv2icgfwelsjObvK20LSMw1T13o okHBfvssDks+BtBlthmDZZ0vV7RqIJwZymTn2lZ9eBPISAzeirPE6jn28UUNXUzxLJIQ y8hob/y5es6FPnDrMSiB23chT+2WHoL9TqgOano2J/F4vK7/gWUB3gdWC+3Iabk77tA0 EETL3PP1i6SORrk6Eut3T6kHlh44bpOuGOedUROZP0/UBCXPlcxAxcNzTleY4vmUzyed DwIw== X-Gm-Message-State: AFqh2krCdREM/4lN8MD3vXDeKjiqs1ojtR0BB0TEBtyS5scfeEI/Qz1I NCcA1Mcl7spDQd6eYHCvwFa61FKcn6+YqqLt0aS0mA== X-Google-Smtp-Source: AMrXdXuuuKT2bxKJ14LORsl1MPDgTLtc1xr4HHO60shSDgnHFBxnsV//IpkEZxYIMzwOctILURRm6BLFnwBEv1J5vyc= X-Received: by 2002:a63:a5e:0:b0:4b4:e491:c331 with SMTP id z30-20020a630a5e000000b004b4e491c331mr654902pgk.19.1674501679691; Mon, 23 Jan 2023 11:21:19 -0800 (PST) MIME-Version: 1.0 References: <20221105194943.826847-1-robimarko@gmail.com> <20221105194943.826847-2-robimarko@gmail.com> <20221107174727.GA7535@thinkpad> <87cz9xcqbd.fsf@kernel.org> <877czn8c2n.fsf@kernel.org> <87k02jzgkz.fsf@kernel.org> <87358hyp3x.fsf@kernel.org> <877cxsdrax.fsf@kernel.org> <87y1q8ccc4.fsf@kernel.org> In-Reply-To: <87y1q8ccc4.fsf@kernel.org> From: Robert Marko Date: Mon, 23 Jan 2023 20:21:08 +0100 Message-ID: Subject: Re: [PATCH 2/2] wifi: ath11k: use unique QRTR instance ID To: Kalle Valo Cc: Manivannan Sadhasivam , Robert Marko , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, elder@linaro.org, hemantk@codeaurora.org, quic_jhugo@quicinc.com, quic_qianyu@quicinc.com, bbhatt@codeaurora.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ansuelsmth@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 12, 2023 at 10:49 AM Kalle Valo wrote: > > Robert Marko writes: > > > On Thu, Jan 12, 2023 at 10:40 AM Kalle Valo wrote: > >> > >> Robert Marko writes: > >> > >> > On Wed, Jan 11, 2023 at 6:10 PM Kalle Valo wrote: > >> >> > >> >> Robert Marko writes: > >> >> > >> >> >> Really sorry, I just didn't manage to get this finalised due to other > >> >> >> stuff and now I'm leaving for a two week vacation :( > >> >> > > >> >> > Any news regarding this, I have a PR for ipq807x support in OpenWrt > >> >> > and the current workaround for supporting AHB + PCI or multiple PCI > >> >> > cards is breaking cards like QCA6390 which are obviously really > >> >> > popular. > >> >> > >> >> Sorry, came back only on Monday and trying to catch up slowly. But I > >> >> submitted the RFC now: > >> >> > >> >> https://patchwork.kernel.org/project/linux-wireless/patch/20230111170033.32454-1-kvalo@kernel.org/ > >> > > >> > Great, thanks for that. > >> > > >> > Does it depend on firmware-2 being available? > >> > >> The final solution for the users will require firmware-2.bin. But for a > >> quick test you can omit the feature bit test by replacing > >> "test_bit(ATH11K_FW_FEATURE_MULTI_QRTR_ID, ab->fw.fw_features)" with > >> "true". Just make sure that the firmware release you are using supports > >> this feature, I believe only recent QCN9074 releases do that. > > > > I was able to test on IPQ8074+QCN9074 yesterday by just bypassing the > > test and it worked. > > > > Sideffect is that until firmware-2.bin is available cards like QCA6390 > > wont work like with my hack. > > Not following here, can you elaborate what won't work with QCA6390? Our downstream hack does not work with QCA6390, so that is why its quite important for OpenWrt to have a generic solution that works on all cards. Regards, Robert > > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr