From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC91C433E1 for ; Mon, 17 Aug 2020 20:14:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C394205CB for ; Mon, 17 Aug 2020 20:14:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QtIODdVO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727964AbgHQUOP (ORCPT ); Mon, 17 Aug 2020 16:14:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727877AbgHQUOJ (ORCPT ); Mon, 17 Aug 2020 16:14:09 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC5F8C061342 for ; Mon, 17 Aug 2020 13:14:08 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id a5so16179853wrm.6 for ; Mon, 17 Aug 2020 13:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8VlkLFchI+j8VaN0Aa8KueyIpTf4adrrVs7ROxwTX3o=; b=QtIODdVO4ECiuttSSX3ZDUVbTPmyWrAuSPKfDKZFglzWehHVe2G3AJtaJ7uM5fEz8z XiE8f3jtzjDEcNkhsK1h18fLiQ2KDlUQqNt25w3fHnCnaZYJzEK6Y798KGC62A7xZTOT DV+aZ+sVVonRzPxVJI5mg8UZmMB7sCLCTYyCCnFmpXWIbWt0mUFCz5HMh5QhPQEDCWdm IMWeHCuaZR4RZ4fVA9bDKTFXgIoH46xoD7xgO7gwLcWl1LWK9AStoAM5LB8S9boZbLdo iIxhmMDo5lWxRKkzGC/86mhvnLiD5+ffSFSHAja3FEq7eIaCt7Pdurngv0xrxSwePrLi 0IGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8VlkLFchI+j8VaN0Aa8KueyIpTf4adrrVs7ROxwTX3o=; b=J+8I61N60CNRP5HUG2jYlsWcfMfzsbK/MkOgsfKCgKQ2yhKsR/SqgWs1RgJ9y7YTm2 ELiA4IvWG7nsOQ7VGAn2cPjAAxLtrFARSU0CkrvRe83YYZ9YKvElT/KTCgyKYOCCzle/ ZMX+cLwldANfpZ93uTUlEsLz+YYvjscBRQ7Wd55xYDRn93YaqrAGgcQIevTiGx4omJSy DUt+qFx9YYsT7mwDv69HGl5V0Q66VmxxWqdi17PXUDab6zXVcS+G22i2JZLtSxlqXgXg 3CzSa3HuRwBGK+VCJEePG9pjaR6LH/+CJdlAPKWN/+V/WRgj76mjMnUQaDMwavCsCvFH UFnw== X-Gm-Message-State: AOAM533jvpMZVF+y0pwmporFIJMhiKSRn3TMuhLntETm5UnynKe59jCw gIhihtQD5nig0bdXt6d2q086BZRQ+RMutDLFIulJ X-Google-Smtp-Source: ABdhPJxyZaqqSl0OTSUqQ8fWDmcJcY7jgNucGRAF1HCmjJHz2qICLDYAnof5gVgT4zP/CdkDSQQCo2m/z0EwaqJka6A= X-Received: by 2002:adf:dcc9:: with SMTP id x9mr18550540wrm.153.1597695246800; Mon, 17 Aug 2020 13:14:06 -0700 (PDT) MIME-Version: 1.0 References: <20200812095639.4062-1-xiangxia.m.yue@gmail.com> <20200813.155348.1997626107228415421.davem@davemloft.net> In-Reply-To: From: =?UTF-8?B?Sm9oYW4gS27DtsO2cw==?= Date: Mon, 17 Aug 2020 13:13:55 -0700 Message-ID: Subject: Re: [PATCH v2] net: openvswitch: introduce common code for flushing flows To: Tonghao Zhang Cc: Joel Fernandes , Gregory Rose , "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , ovs dev , Netdev , rcu , David Miller Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Aug 15, 2020 at 12:48 AM Tonghao Zhang w= rote: > > On Sat, Aug 15, 2020 at 3:28 AM Johan Kn=C3=B6=C3=B6s = wrote: > > > > On Thu, Aug 13, 2020 at 3:53 PM David Miller wrot= e: > > > > > > From: xiangxia.m.yue@gmail.com > > > Date: Wed, 12 Aug 2020 17:56:39 +0800 > > > > > > > From: Tonghao Zhang > > > > > > > > To avoid some issues, for example RCU usage warning and double free= , > > > > we should flush the flows under ovs_lock. This patch refactors > > > > table_instance_destroy and introduces table_instance_flow_flush > > > > which can be invoked by __dp_destroy or ovs_flow_tbl_flush. > > > > > > > > Fixes: 50b0e61b32ee ("net: openvswitch: fix possible memleak on des= troy flow-table") > > > > Reported-by: Johan Kn=C3=B6=C3=B6s > > > > Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/202= 0-August/050489.html > > > > Signed-off-by: Tonghao Zhang > > > > > > Applied, thank you. > > > > Tonghao, does the following change to your commit make sense to be > > able to apply it on 5.6.14 (e3ac9117b18596b7363d5b7904ab03a7d782b40c)? > Not applied cleanly, if necessary I can send v3 for 5.6.14. That would be appreciated. Thanks! > > @@ -393,7 +387,7 @@ void ovs_flow_tbl_destroy(struct flow_table *table) > > > > free_percpu(table->mask_cache); > > kfree_rcu(rcu_dereference_raw(table->mask_array), rcu); > > - table_instance_destroy(table, ti, ufid_ti, false); > > + table_instance_destroy(ti, ufid_ti); > > } > > > > -- > Best regards, Tonghao