From: Geliang Tang <geliangtang@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Peter Krystad <peter.krystad@linux.intel.com>,
netdev@vger.kernel.org, mptcp <mptcp@lists.01.org>,
"To: Phillip Lougher <phillip@squashfs.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>, Coly Li <colyli@suse.de>,
linux-fsdevel@vger.kernel.org," <linux-kernel@vger.kernel.org>
Subject: Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received
Date: Wed, 21 Oct 2020 10:37:33 +0800 [thread overview]
Message-ID: <CA+WQbwuHpxpSLK1Y4bTArNm1QxMQ28WQiFT+gyJoN_Neid3sow@mail.gmail.com> (raw)
In-Reply-To: <20201020163923.6feef9ef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hi Jakub,
Jakub Kicinski <kuba@kernel.org> 于2020年10月21日周三 上午7:39写道：
>
> On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote:
> > This patchset deals with initializations of mptcp_options_received's two
> > fields, ahmac and port.
>
> Applied, but two extra comments:
> - please make sure the commit messages are in imperative form
> e.g. "Initialize x..." rather than "This patches initializes x.."
> - I dropped the Fixes tag from patch 2, and only queued patch 1 for
> stable - patch 2 is a minor clean up, right?
Yes, that's right. Thanks for applying and updating the patches.
-Geliang
>
> Thanks!
prev parent reply other threads:[~2020-10-21 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 10:23 [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received Geliang Tang
2020-10-19 10:23 ` [MPTCP][PATCH net-next 1/2] mptcp: initialize mptcp_options_received's ahmac Geliang Tang
2020-10-19 10:23 ` [MPTCP][PATCH net-next 2/2] mptcp: move mptcp_options_received's port initialization Geliang Tang
2020-10-19 16:27 ` [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received Matthieu Baerts
2020-10-19 20:40 ` Jakub Kicinski
2020-10-20 13:18 ` Matthieu Baerts
2020-10-20 23:39 ` Jakub Kicinski
2020-10-21 2:37 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+WQbwuHpxpSLK1Y4bTArNm1QxMQ28WQiFT+gyJoN_Neid3sow@mail.gmail.com \
--to=geliangtang@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.krystad@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).