From: Vladimir Oltean <olteanv@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: mkl@pengutronix.de, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
kernel@pengutronix.de, netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
david@protonic.nl
Subject: Re: [PATCH v1 2/2] net: dsa: sja1105: fix sja1105_parse_rgmii_delays()
Date: Mon, 25 Nov 2019 12:10:41 +0200 [thread overview]
Message-ID: <CA+h21hoCaT3DpTGgN8Og98P98tUvPS8-zMKWtVxpyObCe30NvQ@mail.gmail.com> (raw)
In-Reply-To: <20191125100259.5147-2-o.rempel@pengutronix.de>
On Mon, 25 Nov 2019 at 12:03, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> This function was using configuration of port 0 in devicetree for all ports.
> In case CPU port was not 0, the delay settings was ignored. This resulted not
> working communication between CPU and the switch.
>
> Fixes: f5b8631c293b ("net: dsa: sja1105: Error out if RGMII delays are requested in DT")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> drivers/net/dsa/sja1105/sja1105_main.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
> index 1238fd68b2cd..34544b1c30dc 100644
> --- a/drivers/net/dsa/sja1105/sja1105_main.c
> +++ b/drivers/net/dsa/sja1105/sja1105_main.c
> @@ -594,15 +594,15 @@ static int sja1105_parse_rgmii_delays(struct sja1105_private *priv,
> int i;
>
> for (i = 0; i < SJA1105_NUM_PORTS; i++) {
> - if (ports->role == XMII_MAC)
> + if (ports[i].role == XMII_MAC)
> continue;
>
> - if (ports->phy_mode == PHY_INTERFACE_MODE_RGMII_RXID ||
> - ports->phy_mode == PHY_INTERFACE_MODE_RGMII_ID)
> + if (ports[i].phy_mode == PHY_INTERFACE_MODE_RGMII_RXID ||
> + ports[i].phy_mode == PHY_INTERFACE_MODE_RGMII_ID)
> priv->rgmii_rx_delay[i] = true;
>
> - if (ports->phy_mode == PHY_INTERFACE_MODE_RGMII_TXID ||
> - ports->phy_mode == PHY_INTERFACE_MODE_RGMII_ID)
> + if (ports[i].phy_mode == PHY_INTERFACE_MODE_RGMII_TXID ||
> + ports[i].phy_mode == PHY_INTERFACE_MODE_RGMII_ID)
> priv->rgmii_tx_delay[i] = true;
>
> if ((priv->rgmii_rx_delay[i] || priv->rgmii_tx_delay[i]) &&
> --
> 2.24.0
>
next prev parent reply other threads:[~2019-11-25 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 10:02 [PATCH v1 1/2] net: dsa: sja1105: print info about probet chip only after every thing was done Oleksij Rempel
2019-11-25 10:02 ` [PATCH v1 2/2] net: dsa: sja1105: fix sja1105_parse_rgmii_delays() Oleksij Rempel
2019-11-25 10:10 ` Vladimir Oltean [this message]
2019-11-25 10:19 ` [PATCH v1 1/2] net: dsa: sja1105: print info about probet chip only after every thing was done Vladimir Oltean
2019-11-25 15:23 ` Andrew Lunn
2019-11-25 10:22 ` Vladimir Oltean
2019-11-25 10:31 ` Oleksij Rempel
2019-11-25 10:39 ` Vladimir Oltean
2019-11-25 11:09 ` Oleksij Rempel
2019-11-25 15:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hoCaT3DpTGgN8Og98P98tUvPS8-zMKWtVxpyObCe30NvQ@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).