From: Vladimir Oltean <olteanv@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
netdev <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Po Liu <po.liu@nxp.com>
Subject: Re: [PATCH net v2 2/3] taprio: Allow users not to specify "flags" when changing schedules
Date: Wed, 29 Jan 2020 13:24:30 +0200 [thread overview]
Message-ID: <CA+h21hoDDULPuhkEDCby0RBs+3r0angFVvyvazvedRTdWX_UYQ@mail.gmail.com> (raw)
In-Reply-To: <20200129.111245.1611718557356636170.davem@davemloft.net>
Hi David,
On Wed, 29 Jan 2020 at 12:14, David Miller <davem@davemloft.net> wrote:
>
> From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> Date: Tue, 28 Jan 2020 15:52:26 -0800
>
> > When any offload mode is enabled, users had to specify the
> > "flags" parameter when adding a new "admin" schedule.
> >
> > This fix allows that parameter to be omitted when adding a new
> > schedule.
> >
> > This will make that we have one source of truth for 'flags'.
> >
> > Fixes: 4cfd5779bd6e ("taprio: Add support for txtime-assist mode")
> > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> > Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> This will visibly change behavior for a feature in a released
> kernel (v5.3 and later) and it means that newer tools will do
> things that don't work in older kernels.
>
> I think your opportunity to adjust these semantics, has therefore,
> long passed.
>
> Sorry.
This is where the kernel-userspace policy escapes me a little bit.
How is this different from having a bug that would cause the "flags"
field to e.g. be ignored? Would the kernel policy make it impossible
for that bug to be fixed?
At some point, the 5.3 kernel will go EOL. When would be a good time
to make the "flags" optional on "tc qdisc replace", without concerns
about different behavior across versions?
Regards,
-Vladimir
next prev parent reply other threads:[~2020-01-29 11:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 23:52 [PATCH net v2 0/3] taprio: Some fixes Vinicius Costa Gomes
2020-01-28 23:52 ` [PATCH net v2 1/3] taprio: Fix enabling offload with wrong number of traffic classes Vinicius Costa Gomes
2020-01-29 10:11 ` David Miller
2020-01-31 18:05 ` Vinicius Costa Gomes
2020-01-28 23:52 ` [PATCH net v2 2/3] taprio: Allow users not to specify "flags" when changing schedules Vinicius Costa Gomes
2020-01-29 10:12 ` David Miller
2020-01-29 11:24 ` Vladimir Oltean [this message]
2020-01-29 12:09 ` David Miller
2020-01-29 12:23 ` Vladimir Oltean
2020-01-29 18:13 ` Vinicius Costa Gomes
2020-01-28 23:52 ` [PATCH net v2 3/3] taprio: Fix still allowing changing the flags during runtime Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hoDDULPuhkEDCby0RBs+3r0angFVvyvazvedRTdWX_UYQ@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).