From: Vladimir Oltean <olteanv@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: Ido Schimmel <idosch@idosch.org>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
murali.policharla@broadcom.com,
Stephen Hemminger <stephen@networkplumber.org>,
Jiri Pirko <jiri@resnulli.us>, Jakub Kicinski <kuba@kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 10/10] net: bridge: implement auto-normalization of MTU for hardware datapath
Date: Thu, 26 Mar 2020 14:25:28 +0200 [thread overview]
Message-ID: <CA+h21hp3LWA79WwAGhrL_SiaqZ=81=1P6HVO2a3WeLjcaTFgAg@mail.gmail.com> (raw)
In-Reply-To: <25bc3bf2-0dea-5667-8aae-c57a2a693bec@cumulusnetworks.com>
On Thu, 26 Mar 2020 at 14:19, Nikolay Aleksandrov
<nikolay@cumulusnetworks.com> wrote:
>
> On 26/03/2020 14:18, Vladimir Oltean wrote:
> > On Thu, 26 Mar 2020 at 14:06, Nikolay Aleksandrov
> > <nikolay@cumulusnetworks.com> wrote:
> >>
> >> On 26/03/2020 13:35, Ido Schimmel wrote:
> >>> On Thu, Mar 26, 2020 at 12:25:20PM +0200, Vladimir Oltean wrote:
> >>>> Hi Ido,
> >>>>
> >>>> On Thu, 26 Mar 2020 at 12:17, Ido Schimmel <idosch@idosch.org> wrote:
> >>>>>
> > [snip]
> >>>
> >>> I think you should be more explicit about it. Did you consider listening
> >>> to 'NETDEV_PRECHANGEMTU' notifications in relevant drivers and vetoing
> >>> unsupported configurations with an appropriate extack message? If you
> >>> can't veto (in order not to break user space), you can still emit an
> >>> extack message.
> >>>
> >>
> >> +1, this sounds more appropriate IMO
> >>
> >
> > And what does vetoing gain me exactly? The practical inability to
> > change the MTU of any interface that is already bridged and applies
> > length check on RX?
> >
>
> I was referring to moving the logic to NETDEV_PRECHANGEMTU, the rest is up to you.
>
If I'm not going to veto, then I don't see a lot of sense in listening
on this particular notifier either. I can do the normalization just
fine on NETDEV_CHANGEMTU.
next prev parent reply other threads:[~2020-03-26 12:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 15:21 [PATCH v2 net-next 00/10] Configure the MTU on DSA switches Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 01/10] net: dsa: configure the MTU for switch ports Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 02/10] net: phy: bcm7xx: Add jumbo frame configuration to PHY Vladimir Oltean
2020-03-25 15:44 ` Heiner Kallweit
2020-03-25 22:45 ` Vladimir Oltean
2020-03-25 23:02 ` Florian Fainelli
2020-03-25 23:21 ` Heiner Kallweit
2020-03-25 15:22 ` [PATCH v2 net-next 03/10] bgmac: Add support for Jumbo frames Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 04/10] bgmac: Add MTU configuration support to the driver Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 05/10] bgmac: Add DMA support to handle frames beyond 8192 bytes Vladimir Oltean
2020-03-25 23:07 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 06/10] net: dsa: b53: Add MTU configuration support Vladimir Oltean
2020-03-25 23:21 ` Florian Fainelli
2020-03-26 0:48 ` Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 07/10] net: dsa: sja1105: Implement the port MTU callbacks Vladimir Oltean
2020-03-25 23:08 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 08/10] net: dsa: vsc73xx: Make the MTU configurable Vladimir Oltean
2020-03-25 23:09 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 09/10] net: dsa: felix: support changing the MTU Vladimir Oltean
2020-03-25 23:10 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 10/10] net: bridge: implement auto-normalization of MTU for hardware datapath Vladimir Oltean
2020-03-25 23:17 ` Florian Fainelli
2020-03-26 0:30 ` Vladimir Oltean
2020-03-26 10:17 ` Ido Schimmel
2020-03-26 10:25 ` Vladimir Oltean
2020-03-26 11:35 ` Ido Schimmel
2020-03-26 11:44 ` Vladimir Oltean
2020-03-26 11:54 ` Ido Schimmel
2020-03-26 12:34 ` Vladimir Oltean
2020-03-26 12:59 ` Ido Schimmel
2020-03-26 12:06 ` Nikolay Aleksandrov
2020-03-26 12:18 ` Vladimir Oltean
2020-03-26 12:19 ` Nikolay Aleksandrov
2020-03-26 12:25 ` Vladimir Oltean [this message]
2020-03-26 12:38 ` Nikolay Aleksandrov
2020-03-26 18:49 ` Jakub Kicinski
2020-03-26 19:41 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+h21hp3LWA79WwAGhrL_SiaqZ=81=1P6HVO2a3WeLjcaTFgAg@mail.gmail.com' \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=murali.policharla@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).