From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
murali.policharla@broadcom.com,
Stephen Hemminger <stephen@networkplumber.org>,
Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
Jakub Kicinski <kuba@kernel.org>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 06/10] net: dsa: b53: Add MTU configuration support
Date: Thu, 26 Mar 2020 02:48:49 +0200 [thread overview]
Message-ID: <CA+h21hpDskX_KkCtJCM68=atwO_yJEtWh==DpKX-FnLp-sQczQ@mail.gmail.com> (raw)
In-Reply-To: <2b5e3b75-bf51-3341-824f-f47feb556f67@gmail.com>
On Thu, 26 Mar 2020 at 01:22, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 3/25/2020 8:22 AM, Vladimir Oltean wrote:
> > From: Murali Krishna Policharla <murali.policharla@broadcom.com>
> >
> > Add b53_change_mtu API to configure mtu settings in B53 switch. Enable
> > jumbo frame support if configured mtu size is for jumbo frame. Also
> > configure BCM583XX devices to send and receive jumbo frames when ports
> > are configured with 10/100 Mbps speed.
> >
> > Signed-off-by: Murali Krishna Policharla <murali.policharla@broadcom.com>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> [snip]
>
> > @@ -658,6 +659,14 @@ static void b53_enable_cpu_port(struct b53_device *dev, int port)
> > b53_brcm_hdr_setup(dev->ds, port);
> >
> > b53_br_egress_floods(dev->ds, port, true, true);
> > +
> > + b53_read32(dev, B53_JUMBO_PAGE, dev->jumbo_pm_reg, &port_mask);
> > +
> > + if (dev->chip_id == BCM583XX_DEVICE_ID)
> > + port_mask |= JPM_10_100_JUMBO_EN;
> > +
> > + port_mask |= BIT(port);
> > + b53_write32(dev, B53_JUMBO_PAGE, dev->jumbo_pm_reg, port_mask);
>
> This should eventually be brought into b53_set_jumbo() where we already
> have existing logic to configure whether to accept jumbo frames and for
> 10/100M ports, too, not strictly necessary for now though:
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> --
> Florian
What do you mean should be done? This?
if (!is5325(dev) && !is5365(dev))
- b53_set_jumbo(dev, dev->enable_jumbo, false);
+ b53_set_jumbo(dev, dev->enable_jumbo, is58xx(dev));
Regards,
-Vladimir
next prev parent reply other threads:[~2020-03-26 0:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 15:21 [PATCH v2 net-next 00/10] Configure the MTU on DSA switches Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 01/10] net: dsa: configure the MTU for switch ports Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 02/10] net: phy: bcm7xx: Add jumbo frame configuration to PHY Vladimir Oltean
2020-03-25 15:44 ` Heiner Kallweit
2020-03-25 22:45 ` Vladimir Oltean
2020-03-25 23:02 ` Florian Fainelli
2020-03-25 23:21 ` Heiner Kallweit
2020-03-25 15:22 ` [PATCH v2 net-next 03/10] bgmac: Add support for Jumbo frames Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 04/10] bgmac: Add MTU configuration support to the driver Vladimir Oltean
2020-03-25 15:22 ` [PATCH v2 net-next 05/10] bgmac: Add DMA support to handle frames beyond 8192 bytes Vladimir Oltean
2020-03-25 23:07 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 06/10] net: dsa: b53: Add MTU configuration support Vladimir Oltean
2020-03-25 23:21 ` Florian Fainelli
2020-03-26 0:48 ` Vladimir Oltean [this message]
2020-03-25 15:22 ` [PATCH v2 net-next 07/10] net: dsa: sja1105: Implement the port MTU callbacks Vladimir Oltean
2020-03-25 23:08 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 08/10] net: dsa: vsc73xx: Make the MTU configurable Vladimir Oltean
2020-03-25 23:09 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 09/10] net: dsa: felix: support changing the MTU Vladimir Oltean
2020-03-25 23:10 ` Florian Fainelli
2020-03-25 15:22 ` [PATCH v2 net-next 10/10] net: bridge: implement auto-normalization of MTU for hardware datapath Vladimir Oltean
2020-03-25 23:17 ` Florian Fainelli
2020-03-26 0:30 ` Vladimir Oltean
2020-03-26 10:17 ` Ido Schimmel
2020-03-26 10:25 ` Vladimir Oltean
2020-03-26 11:35 ` Ido Schimmel
2020-03-26 11:44 ` Vladimir Oltean
2020-03-26 11:54 ` Ido Schimmel
2020-03-26 12:34 ` Vladimir Oltean
2020-03-26 12:59 ` Ido Schimmel
2020-03-26 12:06 ` Nikolay Aleksandrov
2020-03-26 12:18 ` Vladimir Oltean
2020-03-26 12:19 ` Nikolay Aleksandrov
2020-03-26 12:25 ` Vladimir Oltean
2020-03-26 12:38 ` Nikolay Aleksandrov
2020-03-26 18:49 ` Jakub Kicinski
2020-03-26 19:41 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+h21hpDskX_KkCtJCM68=atwO_yJEtWh==DpKX-FnLp-sQczQ@mail.gmail.com' \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=murali.policharla@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).