Re: [PATCH 0/4] gianfar: some assorted cleanup

From: Vladimir Oltean <olteanv@gmail.com>
To: Arseny Solokha <asolokha@kb.kras.ru>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/4] gianfar: some assorted cleanup
Date: Thu, 5 Sep 2019 13:39:41 +0300	[thread overview]
Message-ID: <CA+h21hpbtsJtUSVUqRO1mpi+Y-KxEi-BfesbDF80bgH-QGAAnQ@mail.gmail.com> (raw)
In-Reply-To: <20190904135223.31754-1-asolokha@kb.kras.ru>

On Wed, 4 Sep 2019 at 16:53, Arseny Solokha <asolokha@kb.kras.ru> wrote:
>
> This is a cleanup series for the gianfar Ethernet driver, following up a
> discussion in [1]. It is intended to precede a conversion of gianfar from
> PHYLIB to PHYLINK API, which will be submitted later in its version 2.
> However, it won't make a conversion cleaner, except for the last patch in
> this series. Obviously this series is not intended for -stable.
>
> The first patch looks super controversial to me, as it moves lots of code
> around for the sole purpose of getting rid of static forward declarations
> in two translation units. On the other hand, this change is purely
> mechanical and cannot do any harm other than cluttering git blame output.
> I can prepare an alternative patch for only swapping adjacent functions
> around, if necessary.
>
> The second patch is a trivial follow-up to the first one, making functions
> that are only called from the same translation unit static.
>
> The third patch removes some now unused macro and structure definitions
> from gianfar.h, slipped away from various cleanups in the past.
>
> The fourth patch, also suggested in [1], makes the driver consistently use
> PHY connection type value obtained from a Device Tree node, instead of
> ignoring it and using the one auto-detected by MAC, when connecting to PHY.
> Obviously a value has to be specified correctly in DT source, or omitted
> altogether, in which case the driver will fall back to auto-detection. When
> querying a DT node, the driver will also take both applicable properties
> into account by making a proper API call instead of open-coding the lookup
> half-way correctly.
>
> [1] https://lore.kernel.org/netdev/CA+h21hruqt6nGG5ksDSwrGH_w5GtGF4fjAMCWJne7QJrjusERQ@mail.gmail.com/
>
> Arseny Solokha (4):
>   gianfar: remove forward declarations
>   gianfar: make five functions static
>   gianfar: cleanup gianfar.h
>   gianfar: use DT more consistently when selecting PHY connection type
>
>  drivers/net/ethernet/freescale/gianfar.c      | 4647 ++++++++---------
>  drivers/net/ethernet/freescale/gianfar.h      |   45 -
>  .../net/ethernet/freescale/gianfar_ethtool.c  |   13 -
>  3 files changed, 2303 insertions(+), 2402 deletions(-)
>
> --
> 2.23.0
>

Thanks for the cleanup!

-Vladimir