From: Vladimir Oltean <olteanv@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
John Crispin <john@phrozen.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: Heads up: phylink changes for next merge window
Date: Thu, 13 Feb 2020 18:09:34 +0200 [thread overview]
Message-ID: <CA+h21hqcpW3OtDGUBKQ58ZCLvM=-4D62EY6sjv7+BJhJc55MqQ@mail.gmail.com> (raw)
In-Reply-To: <20200213160612.GD31084@lunn.ch>
Hi Andrew,
On Thu, 13 Feb 2020 at 18:06, Andrew Lunn <andrew@lunn.ch> wrote:
>
> > Correct me if I'm wrong, but if the lack of fixed-link specifier for
> > CPU and DSA ports was not a problem before, but has suddenly started
> > to become a problem with that patch, then simply reverting to the old
> > "legacy" logic from dsa_port_link_register_of() should restore the
> > behavior for those device tree blobs that don't specify an explicit
> > fixed-link?
>
> DSA defines that the DSA driver should initialize CPU ports and DSA
> ports to their maximum speed. You only need fixed-link properties when
> you need to slow the port down, e.g. the SoC on the other end is
> slower. That does not happen very often, so most boards don't have
> fixed-link properties.
>
> It just happens that most of the boards i test with, have a Fast
> Ethernet SoC port, so do have fixed-link properties, and i missed the
> issue for a long time.
>
> Andrew
Grepping for "ethernet = " in arch/arm/boot/dts, I see that the blobs
without fixed-link aren't even in the majority here. There are plenty
of blobs that specify fixed-link even if running at full interface
speed. I wasn't even aware that "no fixed-link specifier" is even a
thing when working with Ioana on that patch.
-Vladimir
next prev parent reply other threads:[~2020-02-13 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 13:38 Heads up: phylink changes for next merge window Russell King - ARM Linux admin
2020-02-13 14:46 ` Russell King - ARM Linux admin
2020-02-13 15:57 ` Vladimir Oltean
2020-02-13 16:06 ` Andrew Lunn
2020-02-13 16:09 ` Vladimir Oltean [this message]
2020-02-13 17:08 ` Russell King - ARM Linux admin
2020-02-13 16:00 ` Andrew Lunn
2020-02-13 17:16 ` Russell King - ARM Linux admin
2020-02-13 17:45 ` Russell King - ARM Linux admin
2020-02-14 10:41 ` Russell King - ARM Linux admin
2020-02-14 13:50 ` Russell King - ARM Linux admin
2020-02-14 15:08 ` Andrew Lunn
2020-02-14 20:42 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+h21hqcpW3OtDGUBKQ58ZCLvM=-4D62EY6sjv7+BJhJc55MqQ@mail.gmail.com' \
--to=olteanv@gmail.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=joabreu@synopsys.com \
--cc=john@phrozen.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=peppe.cavallaro@st.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=sean.wang@mediatek.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).