From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4E7C28CC5 for ; Wed, 5 Jun 2019 17:50:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7F7520717 for ; Wed, 5 Jun 2019 17:50:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IkSPWEcb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbfFERu1 (ORCPT ); Wed, 5 Jun 2019 13:50:27 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:34138 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfFERu1 (ORCPT ); Wed, 5 Jun 2019 13:50:27 -0400 Received: by mail-ed1-f65.google.com with SMTP id c26so7006333edt.1; Wed, 05 Jun 2019 10:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iSoLQiJZbq8dHcU25ejXYMgL717M98Dzet05yZNBEC4=; b=IkSPWEcb9lK0vrQWFLFk1f8zEUYj6D4LaQaoRypmVUM5h9FoTEkre8MDJA9t9uNYgA V5h2tA9SB3s5BCt4vAvlvv7IeN0xwdr069qmsBruMW2IpGiF0E+fDu5MKSXr1iXuzT/q S1vqU0xVY4WkkxKO9ZN15tGcaXXn7OmTJHl4OGkCsXDvKY1WWFdlwmzteM62RKz6QYBs u0ojHCsbDjW1m08PY5dQoerlxtq71lVAvaZ8E4NtOw2qbndRK8Bh0O+RS08hWdqSl3pL FWdzpnCD83/S/a/33NFRLyMoRCoAevaIkr1/cAL0XxKniSa3WKK0luCgt+8Xn0ElzP0e HDrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iSoLQiJZbq8dHcU25ejXYMgL717M98Dzet05yZNBEC4=; b=UgxeWGNGH2r8kJSNoTBfzCK08NZRKKBIDj9fs6xkI9QHbFHbylWo7jQFFJmIfi4VU5 aYFAJvAPO9IfRxYLBbA7BXF0XJs4c+KwkLH90NRU1S9CvQIk/3p0QbshKLv53NuLeMZt 9uH779G2PccIQ093BUPFaNfFDlQOJ4M8LI2YUTRkeiXk3xuIWCV09JgPu0mC5rzEJY5Z MkKi03FbwL/SG4Hnd0Y/Jgh4q8DE+kmqm36lXGONpJ5FhoURCBy7iivig7+Fo5ylAyxF ybwdnTlEcahOveW28pdYtxtjCF80Jdw4R/pNUfQJF3vJBpxHJEcq1OayW7DgCp915K7T WfJg== X-Gm-Message-State: APjAAAXkpE0pe6uhxxWJqKjE3jwtj24TdoE8H51B8NSlZyBRPdThti3d vU/7w9f4YdxsduDyBYMgf/E7v+r8eZE/IMTuepo= X-Google-Smtp-Source: APXvYqxEeVMukTXCt/WHBCYPweUbBJwy2Is7cZq2g5+bjr+Xi2N2XRz/7kmUH407ao+FnY27WfLdei6BaKCBQ1Czw9o= X-Received: by 2002:a50:fd0a:: with SMTP id i10mr43800313eds.117.1559757025835; Wed, 05 Jun 2019 10:50:25 -0700 (PDT) MIME-Version: 1.0 References: <20190604170756.14338-1-olteanv@gmail.com> <20190604.202258.1443410652869724565.davem@davemloft.net> <20190605174547.b4rwbfrzjqzujxno@localhost> In-Reply-To: <20190605174547.b4rwbfrzjqzujxno@localhost> From: Vladimir Oltean Date: Wed, 5 Jun 2019 20:50:15 +0300 Message-ID: Subject: Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver To: Richard Cochran Cc: David Miller , Florian Fainelli , Vivien Didelot , Andrew Lunn , John Stultz , Thomas Gleixner , Stephen Boyd , lkml , netdev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 5 Jun 2019 at 20:45, Richard Cochran wrote: > > On Wed, Jun 05, 2019 at 02:33:52PM +0300, Vladimir Oltean wrote: > > In the meantime: Richard, do you have any objections to this patchset? > > I like the fact that you didn't have to change the dsa or ptp > frameworks this time around. I haven't taken a closer look than that > yet. > > > I was wondering whether the path delay difference between E2E and P2P > > rings any bell to you. > > Can it be that the switch applies corrections in HW? > Yes it can be. It was one of the first things I thought of. Normally it updates the correction field with its own residence time in 1-step L2 event messages (but I use 2 step). It also has a bit called IGNORE2STF (ignore 2-step flag) by which it updates the correction field in all L2 event messages (including sync, thereby violating the spec for a switch, as far as I'm aware). But I'm not setting it. I also looked at egress frames with wireshark and the correction field is zero. > Thanks, > Richard Thanks, -Vladimir