From: Vladimir Oltean <olteanv@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Alex Marginean <alexandru.marginean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Heiko Thiery <heiko.thiery@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next v3 0/3] net: enetc: remove bootloader dependency
Date: Thu, 28 May 2020 11:43:39 +0300 [thread overview]
Message-ID: <CA+h21hruQkYEYatnOSSc6r2EPR+SY-NbcKCRF6sX2oNLy84itg@mail.gmail.com> (raw)
In-Reply-To: <0130cb1878a47efc23f23cf239d0380f@walle.cc>
On Thu, 28 May 2020 at 11:18, Michael Walle <michael@walle.cc> wrote:
>
> Am 2020-05-28 08:38, schrieb Michael Walle:
> > These patches were picked from the following series:
> > https://lore.kernel.org/netdev/1567779344-30965-1-git-send-email-claudiu.manoil@nxp.com/
> > They have never been resent. I've picked them up, addressed Andrews
> > comments, fixed some more bugs and asked Claudiu if I can keep their
> > SOB
> > tags; he agreed. I've tested this on our board which happens to have a
> > bootloader which doesn't do the enetc setup in all cases. Though, only
> > SGMII mode was tested.
> >
> > changes since v2:
> > - removed SOBs from "net: enetc: Initialize SerDes for SGMII and
> > USXGMII
> > protocols" because almost everything has changed.
> > - get a phy_device for the internal PCS PHY so we can use the phy_
> > functions instead of raw mdiobus writes
>
> mhh after reading,
> https://lore.kernel.org/netdev/CA+h21hoq2qkmxDFEb2QgLfrbC0PYRBHsca=0cDcGOr3txy9hsg@mail.gmail.com/
> this seems to be the wrong way of doing it.
>
> -michael
FWIW, some time after the merge window closes, I plan to convert the
felix and seville drivers to mdio_device. It wouldn't be such a big
deal to also convert enetc to phylink then, and also do this
phy_device -> mdio_device for it too.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-05-28 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 6:38 [PATCH net-next v3 0/3] net: enetc: remove bootloader dependency Michael Walle
2020-05-28 6:38 ` [PATCH net-next v3 1/3] net: dsa: felix: move USXGMII defines to common place Michael Walle
2020-05-28 6:38 ` [PATCH net-next v3 2/3] net: enetc: Initialize SerDes for SGMII and USXGMII protocols Michael Walle
2020-05-28 6:38 ` [PATCH net-next v3 3/3] net: enetc: Use DT protocol information to set up the ports Michael Walle
2020-05-28 8:18 ` [PATCH net-next v3 0/3] net: enetc: remove bootloader dependency Michael Walle
2020-05-28 8:43 ` Vladimir Oltean [this message]
2020-05-28 9:11 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hruQkYEYatnOSSc6r2EPR+SY-NbcKCRF6sX2oNLy84itg@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=heiko.thiery@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).