From: Brendan Jackman <jackmanb@google.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
netdev@vger.kernel.org, bpf <bpf@vger.kernel.org>,
"Björn Töpel" <bjorn.topel@intel.com>,
magnus.karlsson@intel.com
Subject: Re: [PATCH bpf-next] samples/bpf: add BPF_ATOMIC_OP macro for BPF samples
Date: Mon, 18 Jan 2021 11:57:59 +0100 [thread overview]
Message-ID: <CA+i-1C1A6wdv3vh4=qLsc6GoOSiD=Wc_oe=PhWKE6tHZ_NQnsg@mail.gmail.com> (raw)
In-Reply-To: <20210118091753.107572-1-bjorn.topel@gmail.com>
I actually deliberately skipped this file, thinking that people were
unlikely to want to add assembly-based atomics code under samples/
I guess it's nice for people to be able to e.g. move/copy code from
the selftests.
On Mon, 18 Jan 2021 at 10:18, Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> From: Björn Töpel <bjorn.topel@intel.com>
>
> Brendan Jackman added extend atomic operations to the BPF instruction
> set in commit 7064a7341a0d ("Merge branch 'Atomics for eBPF'"), which
> introduces the BPF_ATOMIC_OP macro. However, that macro was missing
> for the BPF samples. Fix that by adding it into bpf_insn.h.
>
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Reviewed-by: Brendan Jackman <jackmanb@google.com>
> ---
> samples/bpf/bpf_insn.h | 24 ++++++++++++++++++++----
> 1 file changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/samples/bpf/bpf_insn.h b/samples/bpf/bpf_insn.h
> index db67a2847395..aee04534483a 100644
> --- a/samples/bpf/bpf_insn.h
> +++ b/samples/bpf/bpf_insn.h
> @@ -134,15 +134,31 @@ struct bpf_insn;
> .off = OFF, \
> .imm = 0 })
>
> -/* Atomic memory add, *(uint *)(dst_reg + off16) += src_reg */
> -
> -#define BPF_STX_XADD(SIZE, DST, SRC, OFF) \
> +/*
> + * Atomic operations:
> + *
> + * BPF_ADD *(uint *) (dst_reg + off16) += src_reg
> + * BPF_AND *(uint *) (dst_reg + off16) &= src_reg
> + * BPF_OR *(uint *) (dst_reg + off16) |= src_reg
> + * BPF_XOR *(uint *) (dst_reg + off16) ^= src_reg
> + * BPF_ADD | BPF_FETCH src_reg = atomic_fetch_add(dst_reg + off16, src_reg);
> + * BPF_AND | BPF_FETCH src_reg = atomic_fetch_and(dst_reg + off16, src_reg);
> + * BPF_OR | BPF_FETCH src_reg = atomic_fetch_or(dst_reg + off16, src_reg);
> + * BPF_XOR | BPF_FETCH src_reg = atomic_fetch_xor(dst_reg + off16, src_reg);
> + * BPF_XCHG src_reg = atomic_xchg(dst_reg + off16, src_reg)
> + * BPF_CMPXCHG r0 = atomic_cmpxchg(dst_reg + off16, r0, src_reg)
> + */
> +
> +#define BPF_ATOMIC_OP(SIZE, OP, DST, SRC, OFF) \
> ((struct bpf_insn) { \
> .code = BPF_STX | BPF_SIZE(SIZE) | BPF_ATOMIC, \
> .dst_reg = DST, \
> .src_reg = SRC, \
> .off = OFF, \
> - .imm = BPF_ADD })
> + .imm = OP })
> +
> +/* Legacy alias */
> +#define BPF_STX_XADD(SIZE, DST, SRC, OFF) BPF_ATOMIC_OP(SIZE, BPF_ADD, DST, SRC, OFF)
>
> /* Memory store, *(uint *) (dst_reg + off16) = imm32 */
>
>
> base-commit: 232164e041e925a920bfd28e63d5233cfad90b73
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-01-18 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 9:17 [PATCH bpf-next] samples/bpf: add BPF_ATOMIC_OP macro for BPF samples Björn Töpel
2021-01-18 10:57 ` Brendan Jackman [this message]
2021-01-18 11:00 ` Björn Töpel
2021-01-18 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+i-1C1A6wdv3vh4=qLsc6GoOSiD=Wc_oe=PhWKE6tHZ_NQnsg@mail.gmail.com' \
--to=jackmanb@google.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).