From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB34C433E9 for ; Mon, 11 Jan 2021 19:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27EA922795 for ; Mon, 11 Jan 2021 19:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390640AbhAKTBm (ORCPT ); Mon, 11 Jan 2021 14:01:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390632AbhAKTBl (ORCPT ); Mon, 11 Jan 2021 14:01:41 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 284E1C0617A2 for ; Mon, 11 Jan 2021 11:01:01 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id u19so907859edx.2 for ; Mon, 11 Jan 2021 11:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tk09PpC+xcogiIm0/9iC7HB+xKYL7YMpkQzA09X3gJI=; b=gaWaqsym0Wuvv7s3L+VfphEDAmW8peqlyoG24vVoohje4utDJtwF+dVyLRwcfHH0U/ MfJUnCBI0wV6ic3B7xgdkYH2E1sxICdvpi8c9kXZE6CiVLv1h1o/bHw9fQ4+UzRwh1pt fKQ33o1HcYPNeYGGebMLILKchUVNIlD7PILoD6GjzjqwI4M4Kz2xv0PwmPWu00Yr3evF BdCD+AfSW9+/0cjFUcewiEWU8Iu9OTRt4/TrZirlAhrVy8iz7pcZ2UAz74fUPD7HxO94 v/FBZU2SdY9rTimHSQLsok50m5YO3R9DgjdS9EqoDfD7+DEkhtKLe0qcCrZrT6eYQ7+Q u4UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tk09PpC+xcogiIm0/9iC7HB+xKYL7YMpkQzA09X3gJI=; b=E7DSt54m2TSmiD/P1eTMmac5lYYbhCvg9vmaNtIweFbuT7JIuiHCt9gGpQsuYD9Ykj pONIhWUhxGpVBoeD+a+7fRYDW4TQY7pXODi5YnK6dTRlkkk2LBH4+pkBS/cfuzCykFzH Z8sR4bv7P5i9EVgY3yBBQEIn+M4TNshpBLZXmmM37rqpUC61nlbtGbocgJ6T0BM6TBn+ 4rlGalnuV542RP4V0ubu/gXXVF9hjGzIhNNCNwe0Ad35GDOo8hBvZriB5qCuKkdb1IL0 t8gp+Ph1H9x8wTKFVVTvqA5D6MGU0WZgCF+zH60oU/HEZ91ef1xRrplFC/dxVsPFpjIb HpZA== X-Gm-Message-State: AOAM533IZ6Ro3lTNxGCGCE86GPrl/8+bzX6dP9TrEouLuOV5Y5Gi8/CV KlhhRdNXJnWvfz/cSgkI5fK2K0hTQLannF/+/UbmxalatHtRWQ== X-Google-Smtp-Source: ABdhPJx75LrfqPJangFBrcQTYj525uA2AwQJo04bik00+wCODnHpgnKkrpc7g2u6+aj8spFO24L46U1wDbDDORCFWmo= X-Received: by 2002:aa7:d906:: with SMTP id a6mr586168edr.121.1610391659639; Mon, 11 Jan 2021 11:00:59 -0800 (PST) MIME-Version: 1.0 References: <20210108220930.482456-1-andrii@kernel.org> <20210108220930.482456-8-andrii@kernel.org> In-Reply-To: <20210108220930.482456-8-andrii@kernel.org> From: Hao Luo Date: Mon, 11 Jan 2021 11:00:48 -0800 Message-ID: Subject: Re: [PATCH v2 bpf-next 7/7] selftests/bpf: test kernel module ksym externs To: Andrii Nakryiko Cc: bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Acked-by: Hao Luo On Fri, Jan 8, 2021 at 2:09 PM Andrii Nakryiko wrote: > > Add per-CPU variable to bpf_testmod.ko and use those from new selftest to > validate it works end-to-end. > > Signed-off-by: Andrii Nakryiko > --- > .../selftests/bpf/bpf_testmod/bpf_testmod.c | 3 ++ > .../selftests/bpf/prog_tests/ksyms_module.c | 33 +++++++++++++++++++ > .../selftests/bpf/progs/test_ksyms_module.c | 26 +++++++++++++++ > 3 files changed, 62 insertions(+) > create mode 100644 tools/testing/selftests/bpf/prog_tests/ksyms_module.c > create mode 100644 tools/testing/selftests/bpf/progs/test_ksyms_module.c > > diff --git a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c > index 2df19d73ca49..0b991e115d1f 100644 > --- a/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c > +++ b/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include > #include > #include > #include "bpf_testmod.h" > @@ -10,6 +11,8 @@ > #define CREATE_TRACE_POINTS > #include "bpf_testmod-events.h" > > +DEFINE_PER_CPU(int, bpf_testmod_ksym_percpu) = 123; > + > noinline ssize_t > bpf_testmod_test_read(struct file *file, struct kobject *kobj, > struct bin_attribute *bin_attr, > diff --git a/tools/testing/selftests/bpf/prog_tests/ksyms_module.c b/tools/testing/selftests/bpf/prog_tests/ksyms_module.c > new file mode 100644 > index 000000000000..7fa3d8b6ca30 > --- /dev/null > +++ b/tools/testing/selftests/bpf/prog_tests/ksyms_module.c > @@ -0,0 +1,33 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (c) 2021 Facebook */ > + > +#include > +#include > +#include > +#include "test_ksyms_module.skel.h" > + > +static int duration; > + > +void test_ksyms_module(void) > +{ > + struct test_ksyms_module* skel; > + struct test_ksyms_module__bss *bss; > + int err; > + > + skel = test_ksyms_module__open_and_load(); > + if (CHECK(!skel, "skel_open", "failed to open skeleton\n")) > + return; > + bss = skel->bss; > + > + err = test_ksyms_module__attach(skel); > + if (CHECK(err, "skel_attach", "skeleton attach failed: %d\n", err)) > + goto cleanup; > + > + usleep(1); > + > + ASSERT_EQ(bss->triggered, true, "triggered"); > + ASSERT_EQ(bss->out_mod_ksym_global, 123, "global_ksym_val"); > + > +cleanup: > + test_ksyms_module__destroy(skel); > +} > diff --git a/tools/testing/selftests/bpf/progs/test_ksyms_module.c b/tools/testing/selftests/bpf/progs/test_ksyms_module.c > new file mode 100644 > index 000000000000..d6a0b3086b90 > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/test_ksyms_module.c > @@ -0,0 +1,26 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (c) 2021 Facebook */ > + > +#include "vmlinux.h" > + > +#include > + > +extern const int bpf_testmod_ksym_percpu __ksym; > + > +int out_mod_ksym_global = 0; > +bool triggered = false; > + > +SEC("raw_tp/sys_enter") > +int handler(const void *ctx) > +{ > + int *val; > + __u32 cpu; > + > + val = (int *)bpf_this_cpu_ptr(&bpf_testmod_ksym_percpu); > + out_mod_ksym_global = *val; > + triggered = true; > + > + return 0; > +} > + > +char LICENSE[] SEC("license") = "GPL"; > -- > 2.24.1 >