From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D035DC678D9 for ; Tue, 17 Jan 2023 12:45:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232496AbjAQMp5 (ORCPT ); Tue, 17 Jan 2023 07:45:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236386AbjAQMpy (ORCPT ); Tue, 17 Jan 2023 07:45:54 -0500 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D10DB3867F for ; Tue, 17 Jan 2023 04:45:53 -0800 (PST) Received: by mail-yb1-xb29.google.com with SMTP id c124so33782205ybb.13 for ; Tue, 17 Jan 2023 04:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vxknlLDnsxojLcmQ59vK0ZLgoKiVLvxFkDDOG8faM4Q=; b=uqcNVH96+N3QhwEoMwCX0XF8bNjcpWqYdeKTdHchHyJ1W9LW/wuK5nUhmLsPUlqcjz 7kV/qMP8k1vWUT7gagwrWaw7KqPt9kl/O1+irrBaSgnivLTfRy1btFgNHs0Gl7SiH9ji A532CpWpeNHRHouB4wkT/dQOWzRCmCVnPNfD0yz9tD2N5LAH6g28XDE2L5EmjbPp6huX HmiS0kgY0TYGihNMa3JOOZNERhi1bTob47MaH4+Nrpum65ConMPIFPErUsUSkUeMwqmm 3hVtI2/l7sxxTNcHAoq5MxayhbFf0SXOt3b2IzUI8MGo0MOoUV//HbK6Oam84fX+IabD kN8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vxknlLDnsxojLcmQ59vK0ZLgoKiVLvxFkDDOG8faM4Q=; b=kJnnmuvA+0So6oz+C4KJQ+o6AxM33J0bAgJ08dVXdZb26PNQSlaTW2YdckGGgvgHtq 8rZHDcd/7tGFCsXYAvFuE+KEPmxY/P0Ge5vVCpPOgUDp7udw8KuJenYbm4kfuljbts/K 8ufLCXIs/DeVxeJk3Eg2M7GU0XYDwQQO8yIva64WitmfClNH7kzsp1LM3ovs4Fet9bfu 2qqSeIJ0ayBBZrB+9+pRlBmkfy7RA6FkYZv0UAcxNw+CgPZxW3JPkfbfLMROxTnvrmZ7 0ENqzDU3pcup9cFmqeVHzpSAgwdP1s3xiUnWyBN3NNkr5O4u7rFVgdmm2Y6QPDF4Ulgj h3EA== X-Gm-Message-State: AFqh2kqSSalX52lAh6qBiYAv/SJsa5QyWge02A1AhvMZ5D2M7PcUcbj8 0Rw+5FKAYQ2ZMmacwgOdV4QQ+Wqpyg2oVx3f4BKtRg== X-Google-Smtp-Source: AMrXdXuPODb5km1vVWLEOajbQIs4XSX8t9jdXpVQTtsxlKrB6VmMItgiux+DXoc2jwTxQ8qklnWstNG6QM+ZlY6ut2o= X-Received: by 2002:a25:ca81:0:b0:7d2:891e:ee59 with SMTP id a123-20020a25ca81000000b007d2891eee59mr439542ybg.152.1673959553051; Tue, 17 Jan 2023 04:45:53 -0800 (PST) MIME-Version: 1.0 References: <20230109174511.1740856-1-brgl@bgdev.pl> <20230109174511.1740856-3-brgl@bgdev.pl> <843eed4b-552a-a529-83ed-b813c1346c5f@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Tue, 17 Jan 2023 14:45:42 +0200 Message-ID: Subject: Re: [PATCH 02/18] clk: qcom: add the GCC driver for sa8775p To: Bartosz Golaszewski Cc: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Georgi Djakov , Will Deacon , Robin Murphy , Joerg Roedel , Manivannan Sadhasivam , Jassi Brar , Linus Walleij , Catalin Marinas , Richard Cochran , Srinivas Kandagatla , Vinod Koul , Alex Elder , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Shazad Hussain , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 17 Jan 2023 at 14:44, Bartosz Golaszewski wrote: > > On Mon, Jan 9, 2023 at 10:06 PM Dmitry Baryshkov > wrote: > > > > On 09/01/2023 19:58, Konrad Dybcio wrote: > > > > > > > > > On 9.01.2023 18:44, Bartosz Golaszewski wrote: > > >> From: Shazad Hussain > > >> > > >> Add support for the Global Clock Controller found in the QTI SA8775P > > >> platforms. > > >> > > >> Signed-off-by: Shazad Hussain > > >> [Bartosz: made the driver ready for upstream] > > >> Co-developed-by: Bartosz Golaszewski > > >> Signed-off-by: Bartosz Golaszewski > > >> --- > > > [...] > > > > > > > As the driver didn't get to the list, I'll comment OOB. > > > > Please use clk_regmap_phy_mux_ops where applicable (PCIe PIPE clocks). > > > > Looks like it's impossible for this platform as the PCIe PIPE clocks > have two parents. That's the point, please check the history of other platforms. XO becomes the 'off' state rather than being a separate parent. -- With best wishes Dmitry