From: Reji Thomas <rejithomas.d@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Reji Thomas <rejithomas@juniper.net>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Mathieu Xhonneux <m.xhonneux@gmail.com>,
David Lebrun <david.lebrun@uclouvain.be>
Subject: Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.
Date: Tue, 20 Oct 2020 17:55:20 +0530 [thread overview]
Message-ID: <CAA8Zg7FQL6Ong+70qpbh23ooORJ0C5_mZGCP_Tjw2zYHQBKxAw@mail.gmail.com> (raw)
In-Reply-To: <20201019091702.5b26870c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Oct 19, 2020 at 9:47 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> If we can save the device lookup and still be semantically correct,
> that's probably better.
I am afraid we need to do a device lookup if I am looking up the
neighbor. neigh_lookup
apis expect dev to be passed. If I go through the current lookup ie
ip6_pol_route() I can
drop the dev lookup at risk of returning a non neighbor route as it
exists today.
next prev parent reply other threads:[~2020-10-20 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 8:21 [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif Reji Thomas
2020-10-18 23:01 ` Jakub Kicinski
2020-10-19 3:55 ` Reji Thomas
2020-10-19 16:17 ` Jakub Kicinski
2020-10-20 12:25 ` Reji Thomas [this message]
2020-10-20 9:28 ` Ahmed Abdelsalam
2020-10-20 9:34 ` Ahmed Abdelsalam
2020-10-20 12:35 ` Reji Thomas
2020-10-21 8:12 ` Ahmed Abdelsalam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8Zg7FQL6Ong+70qpbh23ooORJ0C5_mZGCP_Tjw2zYHQBKxAw@mail.gmail.com \
--to=rejithomas.d@gmail.com \
--cc=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=m.xhonneux@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rejithomas@juniper.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).