From: Dave Taht <dave.taht@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
roy.qing.li@gmail.com,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
ghorbel@pivasoftware.com
Subject: Re: [PATCH] ipv6: fix a potential use after free in sit.c
Date: Sat, 18 Oct 2014 10:22:35 -0700 [thread overview]
Message-ID: <CAA93jw7qxXCSkWc4YRyiAJ9bwQnk4PwYX8eKfwZyZ2qnhM7QYQ@mail.gmail.com> (raw)
In-Reply-To: <20141018.130720.448065424567018228.davem@davemloft.net>
On Sat, Oct 18, 2014 at 10:07 AM, David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Indeed, I wish we could somehow automate this.
>
> Yes, I'm sure we could construct some sparse et al. rules but
> I mean at run time. For example, having a special pointer type
> that you can't dereference directly. At the time of assignment
> the pointer gets some kind of state, and pskb_may_pull() et al.
> calls invalidate that "state".
>
> It probably could just be a 2-bit counter which is incremented
> every time skb->data is reallocated.
>
> The captured 2-bit generation count could be stored in the low
> bits of the pointer.
>
> Anyways, just throwing out ideas...
So far as I know, the one machine linux has never been ported
to was a LISP machine. With its 36 bit words, and tagging, that
would do what you want. I had kind of hoped with 64 bits of
addressing some of those ideas would have been reused.
/me misses truly oddball architectures
--
Dave Täht
http://www.bufferbloat.net/projects/bloat/wiki/Upcoming_Talks
next prev parent reply other threads:[~2014-10-18 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 9:33 [PATCH] ipv6: fix a potential use after free in sit.c roy.qing.li
2014-10-18 15:52 ` Eric Dumazet
2014-10-18 17:07 ` David Miller
2014-10-18 17:22 ` Dave Taht [this message]
2014-10-18 17:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA93jw7qxXCSkWc4YRyiAJ9bwQnk4PwYX8eKfwZyZ2qnhM7QYQ@mail.gmail.com \
--to=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ghorbel@pivasoftware.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).