From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6435EC433DF for ; Mon, 3 Aug 2020 10:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EE9320719 for ; Mon, 3 Aug 2020 10:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="U5IJ1EiF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgHCKZN (ORCPT ); Mon, 3 Aug 2020 06:25:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbgHCKZN (ORCPT ); Mon, 3 Aug 2020 06:25:13 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28FE5C06174A for ; Mon, 3 Aug 2020 03:25:13 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id v4so29368585ljd.0 for ; Mon, 03 Aug 2020 03:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q/DGzoF6CXxtHgCXxPInKWoutLOVz6raFMjHyyz/ipo=; b=U5IJ1EiF6Tz96U8sH967hVgdN6eea3a58Qqz9un8vqypSnbKs2aEJ4TPhcj1Axgs9/ 1vxUi7H9lgsLV8PGg1dvx+3ltT0XFwCopKDQ5rjEEYofaDDuabSk5w8/vgRL7llBhkha DYLLhHKEFW1YWXEC87G8XM88E7pFxgfH6ObLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q/DGzoF6CXxtHgCXxPInKWoutLOVz6raFMjHyyz/ipo=; b=SsEyqO3jGzpYRZkf6/yDDUl5eAqUfEyEYQS84HnsLunrt9tHsiLrWlfM1vzcp5TSiU AuH4T7F5WYPdwuAmHQ1h0Qvd3AfkIylMC/fRBCrZ8CT/VRpeMms0VC7wL/l526feq9wa u0GMNGf17fyBHjeNXLvjuEGJ7Gg5DFCAMga2pU3oLUFEv5RwJzOSqwi6n1eOjLZeJ+rM Wz2dTwAJV3PcJKESDV41FO2nvP+FzptwfzKYAdsO5e46FRmgC8Qg2MJxgowTf8Nl/ZLi MgaC+UXOQQTMzSi2UsygZDj1n0trkQnfyaoo9OCYdpnXu8nfgjAtIMB+JrFctYMMKoeJ eaSQ== X-Gm-Message-State: AOAM531Hzr6FDIKxy5NQJtVhl/YakDa27ALxmRcvTDm/UzT/NWNkm2yM efic6q+SZHULXCD3vRoXRp0GRsyeE5CRhB8HvF9bQw== X-Google-Smtp-Source: ABdhPJyj+8rgkMKUp5BqiqiKv+fCWAPz11haw9k4LqSF1romGZ6qE4LKnPblwZYsWksqykQbw9g8AR3k1d/be/o+C3w= X-Received: by 2002:a2e:9010:: with SMTP id h16mr2737548ljg.316.1596450311318; Mon, 03 Aug 2020 03:25:11 -0700 (PDT) MIME-Version: 1.0 References: <1595847753-2234-1-git-send-email-moshe@mellanox.com> In-Reply-To: From: Vasundhara Volam Date: Mon, 3 Aug 2020 15:54:59 +0530 Message-ID: Subject: Re: [PATCH net-next RFC 00/13] Add devlink reload level option To: Jacob Keller Cc: Moshe Shemesh , "David S. Miller" , Jiri Pirko , Netdev , open list Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote: > > > > On 7/27/2020 10:25 PM, Vasundhara Volam wrote: > > On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote: > >> > >> Introduce new option on devlink reload API to enable the user to select the > >> reload level required. Complete support for all levels in mlx5. > >> The following reload levels are supported: > >> driver: Driver entities re-instantiation only. > >> fw_reset: Firmware reset and driver entities re-instantiation. > > The Name is a little confusing. I think it should be renamed to > > fw_live_reset (in which both firmware and driver entities are > > re-instantiated). For only fw_reset, the driver should not undergo > > reset (it requires a driver reload for firmware to undergo reset). > > > > So, I think the differentiation here is that "live_patch" doesn't reset > anything. This seems similar to flashing the firmware and does not reset anything. > > >> fw_live_patch: Firmware live patching only. > > This level is not clear. Is this similar to flashing?? > > > > Also I have a basic query. The reload command is split into > > reload_up/reload_down handlers (Please correct me if this behaviour is > > changed with this patchset). What if the vendor specific driver does > > not support up/down and needs only a single handler to fire a firmware > > reset or firmware live reset command? > > In the "reload_down" handler, they would trigger the appropriate reset, > and quiesce anything that needs to be done. Then on reload up, it would > restore and bring up anything quiesced in the first stage. Yes, I got the "reload_down" and "reload_up". Similar to the device "remove" and "re-probe" respectively. But our requirement is a similar "ethtool reset" command, where ethtool calls a single callback in driver and driver just sends a firmware command for doing the reset. Once firmware receives the command, it will initiate the reset of driver and firmware entities asynchronously.