From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
To: David Miller <davem@davemloft.net>
Cc: "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
Jiri Pirko <jiri@mellanox.com>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] Revert wake_on_lan devlink parameter
Date: Mon, 11 Feb 2019 13:51:23 +0530 [thread overview]
Message-ID: <CAACQVJphNXGCvK5e6+t_HA=_1yVz7BhqBg+1iU9oxGxWnzZpyg@mail.gmail.com> (raw)
In-Reply-To: <20190210.233503.1063032485031175825.davem@davemloft.net>
On Mon, Feb 11, 2019 at 1:05 PM David Miller <davem@davemloft.net> wrote:
>
> From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
> Date: Mon, 11 Feb 2019 10:09:23 +0530
>
> > On Sat, Feb 9, 2019 at 12:37 PM David Miller <davem@davemloft.net> wrote:
> >>
> >> From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
> >> Date: Fri, 8 Feb 2019 14:43:08 +0530
> >>
> >> > As per discussion with Jakub Kicinski and Michal Kubecek,
> >> > this will be better addressed by soon-too-come ethtool netlink
> >> > API with additional indication that given WoL configuration request
> >> > is supposed to be persisted.
> >> >
> >> > Retain bnxt_en code for devlink port param table registration.
> >> > There will be follow up patches to add some devlink port params
> >> > for bnxt_en driver.
> >>
> >> Please fix the kbuild robot reported build failure and repost.
> > David, second patch in this patchset has already taken care of all
> > this failures.
> > Could you please apply both patches together?
>
> You cannot break bisection like this.
>
> If they cannot be separated, resubmit the change as one patch.
Okay. I will resubmit as one patch. Thank you David.
prev parent reply other threads:[~2019-02-11 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 9:13 [PATCH net-next 0/2] Revert wake_on_lan devlink parameter Vasundhara Volam
2019-02-08 9:13 ` [PATCH net-next 1/2] Revert "devlink: Add a generic wake_on_lan port parameter" Vasundhara Volam
2019-02-08 11:00 ` kbuild test robot
2019-02-08 9:13 ` [PATCH net-next 2/2] bnxt_en: Remove wake_on_lan parameter support for devlink Vasundhara Volam
2019-02-09 7:07 ` [PATCH net-next 0/2] Revert wake_on_lan devlink parameter David Miller
2019-02-11 4:39 ` Vasundhara Volam
2019-02-11 7:35 ` David Miller
2019-02-11 8:21 ` Vasundhara Volam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAACQVJphNXGCvK5e6+t_HA=_1yVz7BhqBg+1iU9oxGxWnzZpyg@mail.gmail.com' \
--to=vasundhara-v.volam@broadcom.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).