From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C05C43331 for ; Thu, 26 Mar 2020 16:03:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A228F2073E for ; Thu, 26 Mar 2020 16:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Me/lmt5l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728479AbgCZQDe (ORCPT ); Thu, 26 Mar 2020 12:03:34 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40750 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726296AbgCZQDe (ORCPT ); Thu, 26 Mar 2020 12:03:34 -0400 Received: by mail-lf1-f66.google.com with SMTP id j17so5292157lfe.7 for ; Thu, 26 Mar 2020 09:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QG3ouz6ORFeqDNmtp4i3YMM1Ofd2sLdAsf2ZZXYAIGw=; b=Me/lmt5lMW143w6fwsQYN5uQAfgZOwmcFm0KQQQnR/S8gXmn7WIH9XfGKw58M/5Nby NQnv4eycMKgNbcqGrgbxnxhmeO0bmvPCE6EilY2uk5P1lBdWn0wpUCK6x6iU9b/Zky4+ mxMDUfuBSLonnASGVMCj69ABzCAH0sg6URMlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QG3ouz6ORFeqDNmtp4i3YMM1Ofd2sLdAsf2ZZXYAIGw=; b=Mwg2ZcTeGrprWzhQK9xIsFA777aKZVLrB3S97B/PBYUE8k8+mxl14ZU0UHf2pg7BEG jekY4aqv8Cnm3R/dFjpKcy18GaB99skPBz3HzdbQTMB65+cLT/cHNdH5CdUwRdmLi8u1 OeLNC5pvUuLx0+6RFVg6iS/PMY1H06xG46jzHYismCOgNDmxwq5eZ/fSm0OowU7sO4In zhuChjlGMJDIT/I/rAKwFNu8NDIZ7D0Uk0JHNiqWTB/wjjNTTCjgOwxJ5fzrTN1LE54m VEnwtImeMkafVwsujf8eQWk47TrVPsxOzz5T+/nzawfeTpEKf7gwCvq4PZ+LltWTznrT PwUQ== X-Gm-Message-State: ANhLgQ3XhL+2lryx4wVtG7/PAIKtqiOUC6I45ksqVWFyBV/2FE6uXLpL BZwiBNEM31UXCTTYjU6otAjIYARhT34SgFcMWbMqJg== X-Google-Smtp-Source: ADFU+vt9We4DhFMwyTGpDy3WfouzGVy7kbBr9jnDvg5LnhtmYydha9ls9iG7MBKacq8GptWr1JizWjErahLfkqDI0d0= X-Received: by 2002:a19:ccd3:: with SMTP id c202mr6113167lfg.103.1585238611786; Thu, 26 Mar 2020 09:03:31 -0700 (PDT) MIME-Version: 1.0 References: <1585204021-10317-1-git-send-email-vasundhara-v.volam@broadcom.com> <1585204021-10317-4-git-send-email-vasundhara-v.volam@broadcom.com> <20200326092648.GR11304@nanopsycho.orion> <20200326155429.GZ11304@nanopsycho.orion> In-Reply-To: <20200326155429.GZ11304@nanopsycho.orion> From: Vasundhara Volam Date: Thu, 26 Mar 2020 21:33:20 +0530 Message-ID: Subject: Re: [PATCH v2 net-next 3/7] devlink: Add macro for "hw.addr" to info_get cb. To: Jiri Pirko Cc: David Miller , Netdev , Jiri Pirko , Michael Chan Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 26, 2020 at 9:24 PM Jiri Pirko wrote: > > Thu, Mar 26, 2020 at 12:02:43PM CET, vasundhara-v.volam@broadcom.com wrote: > >On Thu, Mar 26, 2020 at 2:56 PM Jiri Pirko wrote: > >> > >> Thu, Mar 26, 2020 at 07:27:00AM CET, vasundhara-v.volam@broadcom.com wrote: > >> >Add definition and documentation for the new generic info "hw.addr". > >> >"hw.addr" displays the hardware address of the interface. > >> > > >> >Cc: Jiri Pirko > >> >Signed-off-by: Vasundhara Volam > >> >Signed-off-by: Michael Chan > >> >--- > >> > Documentation/networking/devlink/devlink-info.rst | 5 +++++ > >> > include/net/devlink.h | 3 +++ > >> > 2 files changed, 8 insertions(+) > >> > > >> >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst > >> >index 650e2c0e3..56d13c5 100644 > >> >--- a/Documentation/networking/devlink/devlink-info.rst > >> >+++ b/Documentation/networking/devlink/devlink-info.rst > >> >@@ -144,6 +144,11 @@ board.manufacture > >> > > >> > An identifier of the company or the facility which produced the part. > >> > > >> >+hw.addr > >> >+------- > >> >+ > >> >+Hardware address of the interface. > >> >+ > >> > fw > >> > -- > >> > > >> >diff --git a/include/net/devlink.h b/include/net/devlink.h > >> >index d51482f..c9383f4 100644 > >> >--- a/include/net/devlink.h > >> >+++ b/include/net/devlink.h > >> >@@ -476,6 +476,9 @@ enum devlink_param_generic_id { > >> > /* Revision of asic design */ > >> > #define DEVLINK_INFO_VERSION_GENERIC_ASIC_REV "asic.rev" > >> > > >> >+/* Hardware address */ > >> >+#define DEVLINK_INFO_VERSION_GENERIC_HW_ADDR "hw.addr" > >> > >> Wait a second. Is this a MAC. I don't understand why MAC would be here. > >Yes, this is MAC address. Since, most of the information is displayed > >via info_get > >as one place. Would like to display MAC address as well under info_get. > > No, I don't want to display mac here. It is a netdevice attribute. Leave > it there. > Yes, realised it and sent a v3 patchset already, removing the MAC address. Thanks. > > > > >Thanks, > >Vasundhara > > > > > >> If not MAC, what is exactly this address about? > >> > >> > >> >+ > >> > /* Overall FW version */ > >> > #define DEVLINK_INFO_VERSION_GENERIC_FW "fw" > >> > /* Overall FW interface specification version */ > >> >-- > >> >1.8.3.1 > >> >