From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8B5ECE58C for ; Wed, 9 Oct 2019 22:49:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63E48218DE for ; Wed, 9 Oct 2019 22:49:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cOzzPAwz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732383AbfJIWtv (ORCPT ); Wed, 9 Oct 2019 18:49:51 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:32895 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731140AbfJIWtv (ORCPT ); Wed, 9 Oct 2019 18:49:51 -0400 Received: by mail-lf1-f65.google.com with SMTP id y127so2886473lfc.0; Wed, 09 Oct 2019 15:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JQ7IRzTIdaFV+n1nK/yXcwRVj3KRTiTnBvNE62eqmyQ=; b=cOzzPAwzAzkmIWEMYL0RcXpWp/ZMYe1+XLb7aL45jWyMNEboKZRC7WbrRn0hfMQeij q2Gdw2qclJgOvZ72pWuyaSn9c4erB4UHOBOwc/+rsX2Pf8yrmTu721zU1u89VW02w8DC Gj8tSaNx+gtGoPz93dCqluDu5Q3YcmKwrbpp4bkXYCBW//CP51H43mN5bosyJ+S5w94H JmM7WQSom9KPoJp/TNMasK8vqNV1kRJc/xyQohabXLWPpnEdrTRu+OXgGTJKeCPAW96G dYgq5V+bNQ75eQ2dDCeCUpb12rvgJZ60i8pK2oAl5nurPa/nAt/0GT1OttCReRSHzi45 YuOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JQ7IRzTIdaFV+n1nK/yXcwRVj3KRTiTnBvNE62eqmyQ=; b=Ci5NFWZ+vcwOlHtSdDroHuK+GxevzwnS3WK0tBuqrTtTJn+kNIePRiDsa2irHD3LyH l/PEPBrblHtGPis5rWaWePhAmwcgLVO5otKDMHTQh0rw5yiJ6TmiYPlqA5yeCwbKiKBZ CmlxYm9Fi15g3IEmaFT/rYqRhMX+9kyM8YRCsAWsgaJNFPoG4Ksu1MyXtELn3G6eomur q2+MhoUxRO1vPmA5jOYBtTkRPLN2wI7j+GGyBmEp3Js31bi1xRephAjsQ8Wll5baXfBS AH/xDtA9kXfBJ0JF8jp08ginjJ76/E3xvsh2PObZ+0WNu3faFjDJF4VlrN8VCr0hQRuK M9qw== X-Gm-Message-State: APjAAAVNnIEgvw/eyY1I4ckktZHvIYk6i+uDks5b5AdAyDmzJwZg/81Z WwCYioEElZtDnJHqoSgquRPuFyWBayEwhKjo4ek= X-Google-Smtp-Source: APXvYqyLAQD+m08S/pEGauXD73vDUQXux43O0PKPmkPH9K4OCqSDb5frePFQtDa3qXQae2OItATfE/AEGOrKuLhadTI= X-Received: by 2002:a19:4b8f:: with SMTP id y137mr3609940lfa.19.1570661388383; Wed, 09 Oct 2019 15:49:48 -0700 (PDT) MIME-Version: 1.0 References: <20191009164929.17242-1-i.maximets@ovn.org> In-Reply-To: <20191009164929.17242-1-i.maximets@ovn.org> From: Alexei Starovoitov Date: Wed, 9 Oct 2019 15:49:37 -0700 Message-ID: Subject: Re: [PATCH bpf v2] libbpf: fix passing uninitialized bytes to setsockopt To: Ilya Maximets Cc: Network Development , bpf , LKML , Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Jonathan Lemon , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 9, 2019 at 9:49 AM Ilya Maximets wrote: > > 'struct xdp_umem_reg' has 4 bytes of padding at the end that makes > valgrind complain about passing uninitialized stack memory to the > syscall: > > Syscall param socketcall.setsockopt() points to uninitialised byte(s) > at 0x4E7AB7E: setsockopt (in /usr/lib64/libc-2.29.so) > by 0x4BDE035: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:172) > Uninitialised value was created by a stack allocation > at 0x4BDDEBA: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:140) > > Padding bytes appeared after introducing of a new 'flags' field. > memset() is required to clear them. > > Fixes: 10d30e301732 ("libbpf: add flags to umem config") > Signed-off-by: Ilya Maximets Applied. Thanks