From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E447EC3A59E for ; Fri, 16 Aug 2019 05:16:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA5112077C for ; Fri, 16 Aug 2019 05:16:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kDSc6L3x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726482AbfHPFQU (ORCPT ); Fri, 16 Aug 2019 01:16:20 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:34700 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbfHPFQT (ORCPT ); Fri, 16 Aug 2019 01:16:19 -0400 Received: by mail-lj1-f195.google.com with SMTP id x18so4232490ljh.1; Thu, 15 Aug 2019 22:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aXT56wysrSUKT0mrZs1SZsEmms88zrluxlXTsaKbuCw=; b=kDSc6L3xsrMjEexDgEG7IBJJuFT2T/v846y+amyRWBkRInSNhF52xBVOvPO6MACEyF wT3hXV8YBn1JTgAymE+IVXwIIZlHOLbDE8EGS38Bod/ekyYQvD2cwXDU9ZEJeg1MXgn7 n7gj3rQiq/cS7/gfhk+yH07AgWFGZYZfdyTY0zHiA+v1hWQgMyyqXiKRzFXC05oTdA7Y VyZKDOx8FgQQwjrTnLDankfFlTfEQjUhP4MitReZ/OiYl6KSqW+EFNML1RDVDTHh0zJr cyZP/KrmvJQzwUWFyXX+ysQ73SyhCAqoEo95Nx7v9n0OT8VDPAZONWcip6oHeOeVulau 0F7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aXT56wysrSUKT0mrZs1SZsEmms88zrluxlXTsaKbuCw=; b=TGwYR55u9MyXuV5aW5JfqIFdUk70GjloYj0q5X6Rm/2H0f+D1x2TBvRkv9ufz/d4Iy ARs1LV0sT4oIAFiFr948uicp2W5U68RPz+YXy+s55B6M4CIH329ooBAI0gHE9PVznOsm u0/e4zev9AldV7fHZe4GQxs2aSThmeCYqp9spkcqpxO7hotovnbCB3mGmr41TiIpYosn KWc8a8avm2C9jFkdx1q6bIf0ua/WTaiqX+qnXCGkg0n7QizC/pI6ow314fi45KjuRuFJ lOrOMExEUe4EEohC785XYhvWZutwUv+NRYoDM0SyVX3ZZWgNiXpXtK/LI83k0+wRWK+g jeEQ== X-Gm-Message-State: APjAAAUMfpNkXSbzikXF1tK4JymYxP8098h+VcQN/IeY99q1AFCsZqzH xwWPQmTE7W2d587cEmjQCgZzqCsefP1qSmN+odoGXw== X-Google-Smtp-Source: APXvYqzqZ4Qx86aACw9yZh7/lTrjsdYjL6aRwZS74hkZUt90oVG4d4E/63Om/IKiIbXKvlWaSw9WRYmdtVqomXwoV1E= X-Received: by 2002:a2e:7818:: with SMTP id t24mr2839746ljc.210.1565932577762; Thu, 15 Aug 2019 22:16:17 -0700 (PDT) MIME-Version: 1.0 References: <20190814164742.208909-1-sdf@google.com> <20190814164742.208909-3-sdf@google.com> <20190814195330.GL2820@mini-arch> In-Reply-To: From: Alexei Starovoitov Date: Thu, 15 Aug 2019 22:16:06 -0700 Message-ID: Subject: Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip To: Andrii Nakryiko Cc: Stanislav Fomichev , Stanislav Fomichev , Networking , bpf , "David S. Miller" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 14, 2019 at 1:01 PM Andrii Nakryiko wrote: > > > > Let me know if you see a value in highlighting test vs subtest skip. > > > > Other related question is: should we do verbose output in case > > of a skip? Right now we don't do it. > > It might be useful, I guess, especially if it's not too common. But > Alexei is way more picky about stuff like that, so I'd defer to him. I > have no problem with a clean "SKIPPED: / (maybe some > reason for skipping here)" message. Since test_progs prints single number for FAILED tests then single number for SKIPPED tests is fine as well.