From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB99C433B4 for ; Mon, 26 Apr 2021 04:14:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5173F61360 for ; Mon, 26 Apr 2021 04:14:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbhDZEP1 (ORCPT ); Mon, 26 Apr 2021 00:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbhDZEP0 (ORCPT ); Mon, 26 Apr 2021 00:15:26 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC9E2C061574; Sun, 25 Apr 2021 21:14:43 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id s9so4519340ljj.6; Sun, 25 Apr 2021 21:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2beU3f9zZ1QWH8Q9wqMeTxKqBXerQzZKRmfQLF6JixY=; b=pif8qPx9xiP9cCgTCFESfVNFQI+TpvvpdD7q1r3Q9m+mPFH80FCntk2KScy0FKF3hC 4J8LydnLaGWuCx0EaSjDvrV0uWWOvm0Xq2ii/hd8IaOcfvjy/6uBX5EEIYf7Ai+HSlVS eSk1sC13KTLrOXZlHrKUOdWvCZSc0GPNUB3G5wFlrLIdpfAkcLaA8e57DhOc6Re0Y7MZ TZYFZeocWSEcxcV5DoeW8lyaYfUm2W45Oi1G4ouM67Gux+0lH3MYK7gp71fmxW140K8b I3fJJn/xw80H/Ruxj+hGl8tzyqOhGKPeO+iOZu1Z3jx5IciUOllF+V8Nj/6hOjHeSpvU 7GUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2beU3f9zZ1QWH8Q9wqMeTxKqBXerQzZKRmfQLF6JixY=; b=qZZ1QOAaANplbCvZBuwKiDiHG5iwHWkmFpkjeLslW1A+rE0LTMzh9W4oDtUxBJL1oD HmyjNWRSUS6BT15YfpYm99LZNvQxgBYYR9Mqq4RPqjS4439xQhpBt1TqB8ktNppG8fy5 m/cvBH5ixXk++ZnoKBEduhUnLSMNkBFcphGfG7Ovn7AOkXc7gbg9ErygVkZKjI8HfLf/ lyln5vfeFdbVSgDgBxZTkxocsz2ugOuu0PtplS9suKYetkeUfYz4fvaMruO+4VALGz5p BPDD13G6lTyEJENVm+BGXrJmuGyRYEM4lWz8whJL2whNPXV4bT3nh+vhWN7/yU9cdG8G OLuQ== X-Gm-Message-State: AOAM5316f58FGHB7KQB8O6OoVkVYNYG/P1r0EVzoXTWSieHXR4M9Kxzu zlB+3KF8ZDlrqk2o1yhEwnQtoKgAApA5RLT6rAs= X-Google-Smtp-Source: ABdhPJx6O0RR8iQARa/rx+DHLTkonpD7IahkBsWWI/2/C0crCEg5JF9BBZiPQU4uQiVM7oJ1VvYxJF1ce1DiMlJcMTg= X-Received: by 2002:a2e:a491:: with SMTP id h17mr8603296lji.236.1619410482332; Sun, 25 Apr 2021 21:14:42 -0700 (PDT) MIME-Version: 1.0 References: <20210414195147.1624932-1-jolsa@kernel.org> In-Reply-To: From: Alexei Starovoitov Date: Sun, 25 Apr 2021 21:14:31 -0700 Message-ID: Subject: Re: [PATCHv5 bpf-next 0/7] bpf: Tracing and lsm programs re-attach To: Jiri Olsa Cc: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Network Development , bpf , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Julia Lawall Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 15, 2021 at 11:56 PM Jiri Olsa wrote: > > On Thu, Apr 15, 2021 at 04:45:24PM -0700, Alexei Starovoitov wrote: > > On Wed, Apr 14, 2021 at 12:52 PM Jiri Olsa wrote: > > > > > > hi, > > > while adding test for pinning the module while there's > > > trampoline attach to it, I noticed that we don't allow > > > link detach and following re-attach for trampolines. > > > Adding that for tracing and lsm programs. > > > > > > You need to have patch [1] from bpf tree for test module > > > attach test to pass. > > > > > > v5 changes: > > > - fixed missing hlist_del_init change > > > - fixed several ASSERT calls > > > - added extra patch for missing ';' > > > - added ASSERT macros to lsm test > > > - added acks > > > > It doesn't work: > > hi, > I got the same warning when running test without the > patch [1] I mentioned: > 861de02e5f3f bpf: Take module reference for trampoline in module > > I still don't see it in bpf-next/master Finally applied to bpf-next. Thank you and sorry for the delay.