Re: [PATCH bpf-next 0/3] xsk: add new statistics

Re: [PATCH bpf-next 0/3] xsk: add new statistics

[Björn Töpel]

On 2020-07-08 09:28, Ciara Loftus wrote:
> This series introduces new statistics for af_xdp:
> 1. drops due to rx ring being full
> 2. drops due to fill ring being empty
> 3. failures pulling an item from the tx ring
> 
> These statistics should assist users debugging and troubleshooting
> peformance issues and packet drops.
> 
> The statistics are made available though the getsockopt and xsk_diag
> interfaces, and the ability to dump these extended statistics is made
> available in the xdpsock application via the --extra-stats or -x flag.
> 
> A separate patch which will add ss/iproute2 support will follow.
>

+netdev

Thanks for working on this, Ciara!

For the series:
Acked-by: Björn Töpel <bjorn.topel@intel.com>

> Ciara Loftus (3):
>    xsk: add new statistics
>    samples: bpf: add an option for printing extra statistics in xdpsock
>    xsk: add xdp statistics to xsk_diag
> 
>   include/net/xdp_sock.h            |  4 ++
>   include/uapi/linux/if_xdp.h       |  5 +-
>   include/uapi/linux/xdp_diag.h     | 11 ++++
>   net/xdp/xsk.c                     | 36 +++++++++++--
>   net/xdp/xsk_buff_pool.c           |  1 +
>   net/xdp/xsk_diag.c                | 17 ++++++
>   net/xdp/xsk_queue.h               |  6 +++
>   samples/bpf/xdpsock_user.c        | 87 ++++++++++++++++++++++++++++++-
>   tools/include/uapi/linux/if_xdp.h |  5 +-
>   9 files changed, 163 insertions(+), 9 deletions(-)
> 

Re: [PATCH bpf-next 0/3] xsk: add new statistics

[Alexei Starovoitov]

On Wed, Jul 8, 2020 at 4:20 AM Björn Töpel <bjorn.topel@intel.com> wrote:
>
>
>
> On 2020-07-08 09:28, Ciara Loftus wrote:
> > This series introduces new statistics for af_xdp:
> > 1. drops due to rx ring being full
> > 2. drops due to fill ring being empty
> > 3. failures pulling an item from the tx ring
> >
> > These statistics should assist users debugging and troubleshooting
> > peformance issues and packet drops.
> >
> > The statistics are made available though the getsockopt and xsk_diag
> > interfaces, and the ability to dump these extended statistics is made
> > available in the xdpsock application via the --extra-stats or -x flag.
> >
> > A separate patch which will add ss/iproute2 support will follow.
> >
>
> +netdev
>
> Thanks for working on this, Ciara!
>
> For the series:
> Acked-by: Björn Töpel <bjorn.topel@intel.com>

Applied. Thanks