From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D3FC432C0 for ; Wed, 27 Nov 2019 19:33:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C2372080F for ; Wed, 27 Nov 2019 19:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vIGB6nuy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbfK0TdO (ORCPT ); Wed, 27 Nov 2019 14:33:14 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:43184 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727822AbfK0TdO (ORCPT ); Wed, 27 Nov 2019 14:33:14 -0500 Received: by mail-lf1-f67.google.com with SMTP id l14so18090616lfh.10; Wed, 27 Nov 2019 11:33:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RSx7OTjw0zpOYqU/X0SJ0HyqOXCDIW8v0m9WjClqi/s=; b=vIGB6nuya7dBARFwL6uh1DiYOzq9Jys1GzivJONLdY04SYXv4UC7ZOPhw6WqAfC23n LPrzYDsE++IHWb7q3NQQIcJtb6xVjkXFvTfth888vv+nGy7XUk9U6qqNDztXIP3064re JCJQmGmKlGV3vYma9bj19BRsJarwG16feKZZm1gh+bhg8BqI79uYYLZPy9CtybMu/la+ qHry2xprY9N581HzFYnT/E1QdgTBgANf+KFi8bhSVhTrNGnaYIhGqzuEbfGLWdFut48J q1C6unGkgI3hjK2QsgjQeJ9MqH8gzcNTN2IkjcFfTp3gdaMGBCX6ShmxnOAYooUbCz8s 9QAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RSx7OTjw0zpOYqU/X0SJ0HyqOXCDIW8v0m9WjClqi/s=; b=J6z7czPM1xNMWvOuzgXnUfHcdK06Ia/RgUk6455NR729eLoFJSmxy6fObSzBtgPfi3 m0C/HqijyRPK6IpFhmva3S+3x0vztC8JNJnPiY+KPRovPtMgm8Y2xZAk+wkzdtY/yCbB krrp9kMzZcqaNssctInAz7tDPzVDOUz0shxKlKeYFqYv3Ma/CUsicpH3aV01Py96Ixru 0NQ5F4jcHX50h1iXmRqndTkAyDu42BFKh6lp8uSQVyztXElh9J5u6RWwJ1mt5qBfjGTm sSu5tx4nyoAaF0X/6jvh04V1Wxq2Dvx3Z+AIweQvD/P0XL/P6KUoop1g9OhgVZ0XyOEu UlKw== X-Gm-Message-State: APjAAAW5jP0hA6mtklvwFUJhxVq8rXZazWISR/WoYf3n3fBRKrfbEg1z 9ZYwVuosS0dzphILHWLrkH+O47kQm/drXPQBRTOvEg== X-Google-Smtp-Source: APXvYqy7HPCiJyTFwTniD3JzD0iem2k+Ybd0glPQhP2ykdIub0GuS7FZOgktbwp0EhMv0fROSauC/ZqH+aDJTAlO9GE= X-Received: by 2002:a19:888:: with SMTP id 130mr20156546lfi.167.1574883191745; Wed, 27 Nov 2019 11:33:11 -0800 (PST) MIME-Version: 1.0 References: <20191126183451.GC29071@kernel.org> <87d0dexyij.fsf@toke.dk> <20191126190450.GD29071@kernel.org> <20191126221018.GA22719@kernel.org> <20191126221733.GB22719@kernel.org> <20191126231030.GE3145429@mini-arch.hsd1.ca.comcast.net> <20191126155228.0e6ed54c@cakuba.netronome.com> <20191127013901.GE29071@kernel.org> <20191127134553.GC22719@kernel.org> In-Reply-To: <20191127134553.GC22719@kernel.org> From: Alexei Starovoitov Date: Wed, 27 Nov 2019 11:33:00 -0800 Message-ID: Subject: Re: [PATCH] libbpf: Use PRIu64 for sym->st_value to fix build on 32-bit arches To: Arnaldo Carvalho de Melo Cc: Andrii Nakryiko , Jakub Kicinski , Stanislav Fomichev , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Andrii Nakryiko , Adrian Hunter , Alexei Starovoitov , Daniel Borkmann , Jiri Olsa , Martin KaFai Lau , Namhyung Kim , bpf , Networking , linux-perf-users@vger.kernel.org, Linux Kernel Mailing List , Quentin Monnet Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 27, 2019 at 5:45 AM Arnaldo Carvalho de Melo wrote: > > Another fix I'm carrying in my perf/core branch, > > Regards, > > - Arnaldo > > commit 98bb09f90a0ae33125fabc8f41529345382f1498 > Author: Arnaldo Carvalho de Melo > Date: Wed Nov 27 09:26:54 2019 -0300 > > libbpf: Use PRIu64 for sym->st_value to fix build on 32-bit arches > > The st_value field is a 64-bit value, so use PRIu64 to fix this error on > 32-bit arches: > > In file included from libbpf.c:52: > libbpf.c: In function 'bpf_program__record_reloc': > libbpf_internal.h:59:22: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'Elf64_Addr' {aka 'const long long unsigned int'} [-Werror=format=] > libbpf_print(level, "libbpf: " fmt, ##__VA_ARGS__); \ > ^~~~~~~~~~ > libbpf_internal.h:62:27: note: in expansion of macro '__pr' > #define pr_warn(fmt, ...) __pr(LIBBPF_WARN, fmt, ##__VA_ARGS__) > ^~~~ > libbpf.c:1822:4: note: in expansion of macro 'pr_warn' > pr_warn("bad call relo offset: %lu\n", sym->st_value); > ^~~~~~~ > libbpf.c:1822:37: note: format string is defined here > pr_warn("bad call relo offset: %lu\n", sym->st_value); > ~~^ > %llu > > Fixes: 1f8e2bcb2cd5 ("libbpf: Refactor relocation handling") > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Link: https://lkml.kernel.org/n/tip-iabs1wq19c357bkk84p7blif@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index b20f82e58989..6b0eae5c8a94 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -1819,7 +1819,7 @@ static int bpf_program__record_reloc(struct bpf_program *prog, > return -LIBBPF_ERRNO__RELOC; > } > if (sym->st_value % 8) { > - pr_warn("bad call relo offset: %lu\n", sym->st_value); > + pr_warn("bad call relo offset: %" PRIu64 "\n", sym->st_value); Looking at this more... I never liked this PRI stuff. It makes for such unreadable code. How about just typecasting st_value to (long) ?