From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Ciara Loftus <ciara.loftus@intel.com>,
Netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: Re: [PATCH v4 bpf 0/3] AF_XDP Socket Creation Fixes
Date: Thu, 1 Apr 2021 14:49:54 -0700 [thread overview]
Message-ID: <CAADnVQ+LrOpP6WXrKkjdt6pVGoTsRs8SXLHxWQV6OO=GpZJhVQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ+HfNjsbAA0v48CLOgEw0bj4prsg5ZzP3=iU=QGTFWrAbOAng@mail.gmail.com>
On Wed, Mar 31, 2021 at 12:06 AM Björn Töpel <bjorn@kernel.org> wrote:
>
> On Wed, 31 Mar 2021 at 08:43, Ciara Loftus <ciara.loftus@intel.com> wrote:
> >
> > This series fixes some issues around socket creation for AF_XDP.
> >
> > Patch 1 fixes a potential NULL pointer dereference in
> > xsk_socket__create_shared.
> >
> > Patch 2 ensures that the umem passed to xsk_socket__create(_shared)
> > remains unchanged in event of failure.
> >
> > Patch 3 makes it possible for xsk_socket__create(_shared) to
> > succeed even if the rx and tx XDP rings have already been set up by
> > introducing a new fields to struct xsk_umem which represent the ring
> > setup status for the xsk which shares the fd with the umem.
> >
> > v3->v4:
> > * Reduced nesting in xsk_put_ctx as suggested by Alexei.
> > * Use bools instead of a u8 and flags to represent the
> > ring setup status as suggested by Björn.
> >
>
> Thanks, Ciara! LGTM!
>
> Acked-by: Björn Töpel <bjorn@kernel.org>
Applied. Thanks
prev parent reply other threads:[~2021-04-01 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 6:12 [PATCH v4 bpf 0/3] AF_XDP Socket Creation Fixes Ciara Loftus
2021-03-31 6:12 ` [PATCH v4 bpf 1/3] libbpf: ensure umem pointer is non-NULL before dereferencing Ciara Loftus
2021-03-31 6:12 ` [PATCH v4 bpf 2/3] libbpf: restore umem state after socket create failure Ciara Loftus
2021-04-07 18:02 ` Andrii Nakryiko
2021-04-08 5:52 ` Loftus, Ciara
2021-03-31 6:12 ` [PATCH v4 bpf 3/3] libbpf: only create rx and tx XDP rings when necessary Ciara Loftus
2021-03-31 7:05 ` [PATCH v4 bpf 0/3] AF_XDP Socket Creation Fixes Björn Töpel
2021-04-01 21:49 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQ+LrOpP6WXrKkjdt6pVGoTsRs8SXLHxWQV6OO=GpZJhVQ@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ciara.loftus@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).