From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCF9C49361 for ; Sun, 20 Jun 2021 17:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0E23611B0 for ; Sun, 20 Jun 2021 17:47:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbhFTRt3 (ORCPT ); Sun, 20 Jun 2021 13:49:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbhFTRt1 (ORCPT ); Sun, 20 Jun 2021 13:49:27 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EF88C061574; Sun, 20 Jun 2021 10:47:13 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id h4so26146604lfu.8; Sun, 20 Jun 2021 10:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jSu0egrk+uJuS1JJk2PGJ2TdDHfXRrSYXAm3TLzkXqs=; b=BWgpf8jCgoGmhmrzJnePnAIfXCeFk5ITyr/MWWvt8BcV6lzf12/ZUOx9TE/ISEGrUs AkqtMWC5b2kB6ZC/BNb+9ps3eEFCUO3S221gp7jilCvOMSxlMGuUsvbKT6/KLt0yoZ2B 4VZDggahWUM/UuoPOJns8/hKpF4elDh6DuqvGPU/I80GuRkGsVV9ybqmy5TlyAtOv4L9 RaXvWZQHqsVkU6dB9vEGUrj2iYCbxh/oMTCWhYQiVMZTaaay5oAVuOlh0iJgJo1KcbX2 nEA093aOUOhCMzJCbVU5rnSlYNbff74AVp4SF2fiWVnScC1ztVHbev5L9iYV9SsDQMAd 8aRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jSu0egrk+uJuS1JJk2PGJ2TdDHfXRrSYXAm3TLzkXqs=; b=Q+Rxe9+O60p7J/KIgo77nncaYMnpWzXkJcbbSHPzmzkdNZbcLZ/M3JgtVkXZQ7JBTL 4QJTHT5PA49QBDfbjt5KfmVKspdnRCm7S2/8XDe040Xxb5LtbsWGITUzTjxIh1ZBkA2V GQjJG3CE3CfNzHXasXes7pn9noW6sPhb3ycr71ALH3pQ2zaKRUqwAtpFIo+1lb/aFzft Upge4/r2iHfkHKqgVlWeaeZeN1Jyw8vkb90i6t37g+qkygnyNPZC2IePZZyTmkkpfU+E TXNOsmIgX2XUpqO/dRm7XH9khXnjODVnK6q2C06H0WSz9XyZ4X3lRB0/b5cfe7U8WpEl Z9wg== X-Gm-Message-State: AOAM531NnizTKK3Jnj7gKjEHXsJhmQ3Zs4nByxZr7UqoEijfv5IPDZx/ c8rVLDC8oShSN117Tv+Yh+8jwGkrUSP3HId4SYU= X-Google-Smtp-Source: ABdhPJyeY4ZI9kOyU+NN3y95rXR3jqTYyAs+KReWga/bOW8fK4lJcVMkDqdROiqrirsg2Zv8XgR1v7lISI9LqD2g6aA= X-Received: by 2002:ac2:4e82:: with SMTP id o2mr2444031lfr.38.1624211231674; Sun, 20 Jun 2021 10:47:11 -0700 (PDT) MIME-Version: 1.0 References: <20210605111034.1810858-1-jolsa@kernel.org> <4af931a5-3c43-9571-22ac-63e5d299fa42@fb.com> In-Reply-To: From: Alexei Starovoitov Date: Sun, 20 Jun 2021 10:47:00 -0700 Message-ID: Subject: Re: [RFCv3 00/19] x86/ftrace/bpf: Add batch support for direct/tracing attach To: Yonghong Song Cc: Jiri Olsa , Andrii Nakryiko , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "Steven Rostedt (VMware)" , Networking , bpf , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , Daniel Xu , Viktor Malik Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jun 20, 2021 at 9:57 AM Yonghong Song wrote: > > > > ah right, should have checked it.. so how about we change > > trampoline code to store ip in ctx-8 and make bpf_get_func_ip(ctx) > > to return [ctx-8] > > This should work. Thanks! +1 and pls make it always inline into single LDX insn in the verifier. For both mass attach and normal fentry/fexit.