From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Alexei Starovoitov <ast@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf] bpf, x64: fix stack layout of JITed bpf code
Date: Sat, 15 Jun 2019 14:46:03 -0700 [thread overview]
Message-ID: <CAADnVQK2Nq6_HQT7Opn1XkA7s6UteVE_qOpXq8AiQwFOmeB6jA@mail.gmail.com> (raw)
In-Reply-To: <20190614230821.3146272-1-ast@kernel.org>
On Fri, Jun 14, 2019 at 4:10 PM Alexei Starovoitov <ast@kernel.org> wrote:
>
> Since commit 177366bf7ceb the %rbp stopped pointing to %rbp of the
> previous stack frame. That broke frame pointer based stack unwinding.
> This commit is a partial revert of it.
> Note that the location of tail_call_cnt is fixed, since the verifier
> enforces MAX_BPF_STACK stack size for programs with tail calls.
>
> Fixes: 177366bf7ceb ("bpf: change x86 JITed program stack layout")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Applied to bpf tree.
prev parent reply other threads:[~2019-06-15 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 23:08 [PATCH bpf] bpf, x64: fix stack layout of JITed bpf code Alexei Starovoitov
2019-06-15 21:46 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQK2Nq6_HQT7Opn1XkA7s6UteVE_qOpXq8AiQwFOmeB6jA@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).