Netdev Archive on
 help / color / Atom feed
From: Alexei Starovoitov <>
To: Stanislav Fomichev <>
Cc: Network Development <>,
	bpf <>,
	"David S. Miller" <>,
	Alexei Starovoitov <>,
	Daniel Borkmann <>,
	Lawrence Brakmo <>
Subject: Re: [PATCH bpf] selftests/bpf: de-flake test_tcpbpf
Date: Wed, 4 Dec 2019 18:01:53 -0800
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Dec 4, 2019 at 11:09 AM Stanislav Fomichev <> wrote:
> It looks like BPF program that handles BPF_SOCK_OPS_STATE_CB state
> can race with the bpf_map_lookup_elem("global_map"); I sometimes
> see the failures in this test and re-running helps.
> Since we know that we expect the callback to be called 3 times (one
> time for listener socket, two times for both ends of the connection),
> let's export this number and add simple retry logic around that.
> Also, let's make EXPECT_EQ() not return on failure, but continue
> evaluating all conditions; that should make potential debugging
> easier.
> With this fix in place I don't observe the flakiness anymore.
> Cc: Lawrence Brakmo <>
> Signed-off-by: Stanislav Fomichev <>

Applied. Thanks

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 19:09 Stanislav Fomichev
2019-12-05  2:01 ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on

Archives are clonable:
	git clone --mirror netdev/git/0.git
	git clone --mirror netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ \
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone