From: Yury Norov <yury.norov@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Menglong Dong <imagedong@tencent.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Petr Machata <petrm@nvidia.com>
Subject: Re: [PATCH 0/4] net: drop netif_attrmask_next*()
Date: Mon, 3 Oct 2022 17:43:55 -0700 [thread overview]
Message-ID: <CAAH8bW-6iS4bdfCGHSZa4U9=g8rWb78fA80dfQjyuGpAkY5bzQ@mail.gmail.com> (raw)
In-Reply-To: <20221003172953.128735bf@kernel.org>
On Mon, Oct 3, 2022 at 5:29 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 3 Oct 2022 17:07:31 -0700 Yury Norov wrote:
> > > I see. Is that patch merged and on it's way?
> >
> > This patch is already in pull request.
> >
> > > Perhaps we can just revert it and try again after the merge window?
> >
> > I don't understand this. To me it looks fairly normal - the check has
> > been fixed and merged (likely) in -rc1. After that we have 2 month to
> > spot, fix and test all issues discovered with correct cpumask_check().
> >
> > I'm not insisting in moving this series in -rc1. Let's give it review
> > and careful testing, and merge in -rc2, 3 or whatever is appropriate.
> >
> > Regarding cpumask_check() patch - I'd like to have it in -rc1 because
> > it will give people enough time to test their code...
>
> AFAIU you can keep the cpumask_check() patch, we just need to revert
> the netdev patch from your earlier series?
Yeah, I meant the "net: fix cpu_max_bits_warn() usage in
netif_attrmask_next{,_and}".
> If so I strongly prefer that we revert the broken cleanup rather than
> try to pile on more re-factoring.
What do you mean by broken cleanup? Netdev patch is acked by you,
and this series didn't receive negative feedback so far.
> The trees are not going anywhere, we can queue the patches for 6.2.
Sure, 6.2 is OK as well, but I think any 6.1-rc would be more appropriate.
prev parent reply other threads:[~2022-10-04 0:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 15:16 [PATCH 0/4] net: drop netif_attrmask_next*() Yury Norov
2022-10-02 15:16 ` [PATCH 1/4] net: move setup code out of mutex in __netif_set_xps_queue() Yury Norov
2022-10-02 15:17 ` [PATCH 2/4] net: merge XPS_CPU_DEV_MAPS_SIZE and XPS_RXQ_DEV_MAPS_SIZE macros Yury Norov
2022-10-02 15:17 ` [PATCH 3/4] net: initialize online_mask unconditionally in __netif_set_xps_queue() Yury Norov
2022-10-02 16:58 ` Yury Norov
2022-10-02 15:17 ` [PATCH 4/4] net: fix opencoded for_each_and_bit() " Yury Norov
2022-10-03 16:50 ` [PATCH 0/4] net: drop netif_attrmask_next*() Jakub Kicinski
2022-10-03 18:11 ` Yury Norov
2022-10-03 23:25 ` Jakub Kicinski
2022-10-04 0:07 ` Yury Norov
2022-10-04 0:29 ` Jakub Kicinski
2022-10-04 0:43 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAH8bW-6iS4bdfCGHSZa4U9=g8rWb78fA80dfQjyuGpAkY5bzQ@mail.gmail.com' \
--to=yury.norov@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).