From: Erik Kline <ek@google.com>
To: "Ian K. Coolidge" <icoolidge@google.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] iproute2: ip addr: Accept 'optimistic' flag
Date: Sat, 23 May 2020 22:06:43 -0700 [thread overview]
Message-ID: <CAAedzxqg8SJgwtvq=G9ZytAGhpZ=Q7MwJNPsm-XYs0p_zo-7ug@mail.gmail.com> (raw)
In-Reply-To: <20200524015144.44017-1-icoolidge@google.com>
[-- Attachment #1: Type: text/plain, Size: 2894 bytes --]
patched and tested on a 5.6.13 system
Acked-by: Erik Kline <ek@google.com>
On Sat, 23 May 2020 at 19:01, Ian K. Coolidge <icoolidge@google.com> wrote:
>
> This allows addresses added to use IPv6 optimistic DAD.
> ---
> ip/ipaddress.c | 7 ++++++-
> man/man8/ip-address.8.in | 7 ++++++-
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 80d27ce2..48cf5e41 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -72,7 +72,7 @@ static void usage(void)
> " [-]tentative | [-]deprecated | [-]dadfailed | temporary |\n"
> " CONFFLAG-LIST ]\n"
> "CONFFLAG-LIST := [ CONFFLAG-LIST ] CONFFLAG\n"
> - "CONFFLAG := [ home | nodad | mngtmpaddr | noprefixroute | autojoin ]\n"
> + "CONFFLAG := [ home | nodad | optimistic | mngtmpaddr | noprefixroute | autojoin ]\n"
> "LIFETIME := [ valid_lft LFT ] [ preferred_lft LFT ]\n"
> "LFT := forever | SECONDS\n"
> "TYPE := { vlan | veth | vcan | vxcan | dummy | ifb | macvlan | macvtap |\n"
> @@ -2335,6 +2335,11 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)
> ifa_flags |= IFA_F_HOMEADDRESS;
> else
> fprintf(stderr, "Warning: home option can be set only for IPv6 addresses\n");
> + } else if (strcmp(*argv, "optimistic") == 0) {
> + if (req.ifa.ifa_family == AF_INET6)
> + ifa_flags |= IFA_F_OPTIMISTIC;
> + else
> + fprintf(stderr, "Warning: optimistic option can be set only for IPv6 addresses\n");
> } else if (strcmp(*argv, "nodad") == 0) {
> if (req.ifa.ifa_family == AF_INET6)
> ifa_flags |= IFA_F_NODAD;
> diff --git a/man/man8/ip-address.8.in b/man/man8/ip-address.8.in
> index 2a553190..fe773c91 100644
> --- a/man/man8/ip-address.8.in
> +++ b/man/man8/ip-address.8.in
> @@ -92,7 +92,7 @@ ip-address \- protocol address management
>
> .ti -8
> .IR CONFFLAG " := "
> -.RB "[ " home " | " mngtmpaddr " | " nodad " | " noprefixroute " | " autojoin " ]"
> +.RB "[ " home " | " mngtmpaddr " | " nodad " | " optimstic " | " noprefixroute " | " autojoin " ]"
>
> .ti -8
> .IR LIFETIME " := [ "
> @@ -258,6 +258,11 @@ stateless auto-configuration was active.
> (IPv6 only) do not perform Duplicate Address Detection (RFC 4862) when
> adding this address.
>
> +.TP
> +.B optimistic
> +(IPv6 only) When performing Duplicate Address Detection, use the RFC 4429
> +optimistic variant.
> +
> .TP
> .B noprefixroute
> Do not automatically create a route for the network prefix of the added
> --
> 2.27.0.rc0.183.gde8f92d652-goog
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3842 bytes --]
next prev parent reply other threads:[~2020-05-24 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 1:51 [PATCH] iproute2: ip addr: Accept 'optimistic' flag Ian K. Coolidge
2020-05-24 5:06 ` Erik Kline [this message]
2020-05-24 19:09 ` Stephen Hemminger
2020-05-27 18:03 ` [PATCH v2 1/2] iproute2: ip addr: Organize flag properties structurally Ian K. Coolidge
2020-05-27 18:03 ` [PATCH v2 2/2] iproute2: ip addr: Add support for setting 'optimistic' Ian K. Coolidge
2020-05-31 23:09 ` [PATCH v2 1/2] iproute2: ip addr: Organize flag properties structurally David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAedzxqg8SJgwtvq=G9ZytAGhpZ=Q7MwJNPsm-XYs0p_zo-7ug@mail.gmail.com' \
--to=ek@google.com \
--cc=icoolidge@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).