From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42718C4727F for ; Mon, 28 Sep 2020 09:06:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED06421D7F for ; Mon, 28 Sep 2020 09:06:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="CuyOduRh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgI1JGO (ORCPT ); Mon, 28 Sep 2020 05:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726461AbgI1JGO (ORCPT ); Mon, 28 Sep 2020 05:06:14 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A148C061755 for ; Mon, 28 Sep 2020 02:06:14 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id 95so166269ota.13 for ; Mon, 28 Sep 2020 02:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aLMEwo1GTL8rxXudG0GEtZJfPOiss5JdOgm8YTgj2ew=; b=CuyOduRhEkNZODuCVzegsNXw2bIgsJ/2DykzPHgIqv0B1FArA+4Lxc3NeipV062q/H GIoxRScktP5IDFGaNlu/6riiJ2zJ4MlUQqqTYVUx8OhazSEjtFnbLowDUf54dXhw8C7/ 6R+tL7c1tsD/hykM3Bo5VCGy61woKjidXTSMo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aLMEwo1GTL8rxXudG0GEtZJfPOiss5JdOgm8YTgj2ew=; b=Jh0kIfa//jPx4oTIZxf+1PjfPUNR11dyVGozdvsY8w1gvvycOChIkLfxc99ike4e3y 3BiF+JT2HzETRyWmTRO5MC5L/9LViIZezIsSmYgT7DOpNGy16EupcoeGc7bDp1YkJOKu Q/6NcOXC6/s/j2W20uygCz9JEr5g/tDikfJL/542TTSKqjhbKRHv6QcbIvM43N1BO1zr hEe+d+xE7V29+xzMNko7MpocLkhkDvDuAs3631yYUWg+YInE++G8p3jmzgUYcBBegi3b DemXUE/lBOyEpWOiPYnLd+IrfYHp9Ww5/Ay9jrE9TzKoRs0kg5cgq2t//sbHi86dGr+g g6eg== X-Gm-Message-State: AOAM533Kgcfv1VuiWeR/xT15amfkY9Qn3CpeDWW8nhlj1MXZwDDGAUaQ SLFRWh/hpBCuNasK7xt4cxpHMVNyz7Seck67O6x7Hw== X-Google-Smtp-Source: ABdhPJxs/FZB02Ft8ZmDTuS0bYLgBEPkG0xHeAkww2lbFRxtnPCC8MW6Nr++yZFeBJr/uUIJk4Ekbp6bKiCXxI/Gyrs= X-Received: by 2002:a05:6830:12c7:: with SMTP id a7mr308019otq.334.1601283973942; Mon, 28 Sep 2020 02:06:13 -0700 (PDT) MIME-Version: 1.0 References: <20200925095630.49207-1-lmb@cloudflare.com> <20200925095630.49207-2-lmb@cloudflare.com> <20200925215359.l5lbicqdyx44spoc@kafai-mbp> In-Reply-To: <20200925215359.l5lbicqdyx44spoc@kafai-mbp> From: Lorenz Bauer Date: Mon, 28 Sep 2020 10:06:02 +0100 Message-ID: Subject: Re: [PATCH bpf-next 1/4] bpf: sockmap: enable map_update_elem from bpf_iter To: Martin KaFai Lau Cc: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Jakub Sitnicki , "David S. Miller" , Jakub Kicinski , kernel-team , Networking , bpf , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 25 Sep 2020 at 22:54, Martin KaFai Lau wrote: > > > + if (unlikely(!sk)) > sk_fullsock(sk) test is also needed. > > > + return -EINVAL; > > > + > > if (!sock_map_sk_is_suitable(sk)) > sk->sk_type is used in sock_map_sk_is_suitable(). > sk_type is not in sock_common. Oh my, thanks! -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com