From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC794C433E6 for ; Fri, 12 Feb 2021 10:59:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FF6564E79 for ; Fri, 12 Feb 2021 10:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231148AbhBLK7x (ORCPT ); Fri, 12 Feb 2021 05:59:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbhBLK7u (ORCPT ); Fri, 12 Feb 2021 05:59:50 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA360C061574 for ; Fri, 12 Feb 2021 02:58:54 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id p21so12459765lfu.11 for ; Fri, 12 Feb 2021 02:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aCdl6xS/yVJp5Nl7mhEYBP6S5Y+b/9q9qCwgCmlGQQE=; b=Nd7D08C6QZXWVMkUKkcBrBPmPLJ8Y9A5p66s4YYeO/KTmwpLyUnfNViVHreZxOYt8f 16Mwfe20mTpDdjMeNttWSo95sPFFGTsu9b9YKUUnTuClYDXEGativjGB7D82W7oyfQ8u wRt7xbuzJWyziuaaUSSvE1BQNaHaLzMCGGNVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aCdl6xS/yVJp5Nl7mhEYBP6S5Y+b/9q9qCwgCmlGQQE=; b=gBqwe5BMevgLJECNl/t+6hYi8aATHSjyOp55/jVp/jFKnw8+l/ih3ED7EQXmJsXLYv LPCQ7gvGiSAHUhel+h0sL2zgx6ixetNv5lqpQuFau7kn4QVDrlsUkQ1ZyTKMMTm/6VjM l8FdfLK1QkcLS50Gyk0HY+FrQy2vzmIi20eIWRl/Xk4lAALbqvmBGScgGf7mvlwAZ9Ht OCiv7p1ys+uBjoNSwM5J8KbJsMypC/pOWMbFAhbzIEUzKmm8h4FD6ucVoeTTPK35eCyd sk1Qbc+BI2zhlGZuwfUgYHrct8+PY4i3inMvOj2RetnoSPJ7yoX8uSlZlLmvnFQ+3xxB QjIQ== X-Gm-Message-State: AOAM530ghHyIqkhG+zOwB14PFebI2ypHUr5CFHYH7pKo/myHnFywS277 Hfjl/sW1QDHiXEWy0GbX7ItWVUfiLqOtg4V6aMibbQ== X-Google-Smtp-Source: ABdhPJyjtQBACFtEed271bZN/M1Ef3JGWDwWO+HQflqG73mqOtcxmBfewpTme7AHwhpdOwDFK/MzF8btczQdpqj2TUA= X-Received: by 2002:ac2:58f8:: with SMTP id v24mr1318891lfo.56.1613127533108; Fri, 12 Feb 2021 02:58:53 -0800 (PST) MIME-Version: 1.0 References: <20210210022136.146528-1-xiyou.wangcong@gmail.com> <20210210022136.146528-5-xiyou.wangcong@gmail.com> In-Reply-To: <20210210022136.146528-5-xiyou.wangcong@gmail.com> From: Lorenz Bauer Date: Fri, 12 Feb 2021 10:58:42 +0000 Message-ID: Subject: Re: [Patch bpf-next v2 4/5] skmsg: use skb ext instead of TCP_SKB_CB To: Cong Wang Cc: Networking , bpf , duanxiongchun@bytedance.com, wangdongdong.6@bytedance.com, jiang.wang@bytedance.com, Cong Wang , John Fastabend , Daniel Borkmann , Jakub Sitnicki Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 10 Feb 2021 at 02:22, Cong Wang wrote: > > From: Cong Wang > > Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly > does not work for any other non-TCP protocols. We can move them to > skb ext instead of playing with skb cb, which is harder to make > correct. Reviewed-by: Lorenz Bauer -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com