netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: Manish Chopra <manishc@marvell.com>
Cc: David Miller <davem@davemloft.net>,
	Netdev <netdev@vger.kernel.org>,
	aelior@marvell.com, skalluru@marvell.com
Subject: Re: [PATCH net 1/1] qede: Disable hardware gro when xdp prog is installed
Date: Thu, 19 Dec 2019 14:29:26 -0800	[thread overview]
Message-ID: <CACKFLi=SPzHRXXMYXNecRjYNaKVZ5uOz1DAhZXXLLF4A+Wh2mA@mail.gmail.com> (raw)
In-Reply-To: <20191219183516.7017-1-manishc@marvell.com>

On Thu, Dec 19, 2019 at 10:35 AM Manish Chopra <manishc@marvell.com> wrote:
>
> commit 18c602dee472 ("qede: Use NETIF_F_GRO_HW.") introduced
> a regression in driver that when xdp program is installed on
> qede device, device's aggregation feature (hardware GRO) is not
> getting disabled, which is unexpected with xdp.
>
> Fixes: 18c602dee472 ("qede: Use NETIF_F_GRO_HW.")
> Signed-off-by: Manish Chopra <manishc@marvell.com>
> Signed-off-by: Ariel Elior <aelior@marvell.com>

Reviewed-by: Michael Chan <michael.chan@broadcom.com>

  reply	other threads:[~2019-12-19 22:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 18:35 [PATCH net 1/1] qede: Disable hardware gro when xdp prog is installed Manish Chopra
2019-12-19 22:29 ` Michael Chan [this message]
2019-12-21  5:46 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACKFLi=SPzHRXXMYXNecRjYNaKVZ5uOz1DAhZXXLLF4A+Wh2mA@mail.gmail.com' \
    --to=michael.chan@broadcom.com \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=skalluru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).