From: Michael Chan <michael.chan@broadcom.com>
To: Nikita Kiryushin <kiryushin@ancud.ru>
Cc: Pavan Chebbi <pavan.chebbi@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] tg3: Remove residual error handling in tg3_suspend
Date: Thu, 7 Mar 2024 14:38:01 -0800 [thread overview]
Message-ID: <CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZkGaC9jfvFXrQ@mail.gmail.com> (raw)
In-Reply-To: <4e7e11f8-03b5-4289-9475-d3b4e105d40a@ancud.ru>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Thu, Mar 7, 2024 at 11:23 AM Nikita Kiryushin <kiryushin@ancud.ru> wrote:
>
>
> As of now, tg3_power_down_prepare always ends with success, but
> the error handling code from former tg3_set_power_state call is still here.
>
> Remove (now unreachable) code for simplification.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management")
> Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
The patch looks good to me. But I think we can go one step further
and change tg3_power_down_prepare() to a void function. Thanks.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
next prev parent reply other threads:[~2024-03-07 22:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 19:23 [PATCH] tg3: Remove residual error handling in tg3_suspend Nikita Kiryushin
2024-03-07 22:38 ` Michael Chan [this message]
2024-03-11 15:45 ` [PATCH v2] " Nikita Kiryushin
2024-03-11 17:22 ` Michael Chan
2024-03-26 18:35 ` [PATCH net-next " Nikita Kiryushin
2024-03-27 2:44 ` Ratheesh Kannoth
2024-03-27 3:24 ` Jakub Kicinski
2024-03-27 5:09 ` Michael Chan
2024-03-27 5:13 ` [EXTERNAL] " Ratheesh Kannoth
2024-03-29 1:10 ` Jakub Kicinski
2024-03-29 11:51 ` Nikita Kiryushin
2024-03-29 15:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZkGaC9jfvFXrQ@mail.gmail.com \
--to=michael.chan@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kiryushin@ancud.ru \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).