From: Linus Walleij <linus.walleij@linaro.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Russell King" <linux@armlinux.org.uk>,
netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"René van Dorst" <opensource@vdorst.com>,
"Frank Wunderlich" <frank-w@public-files.de>
Subject: Re: [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support
Date: Mon, 18 Jan 2021 15:55:30 +0100 [thread overview]
Message-ID: <CACRpkdYA2fWF_1K+2aYoZnBAsm9H3=VHpeT4ZDU5sCdrOUWx=w@mail.gmail.com> (raw)
In-Reply-To: <20210111054428.3273-3-dqfext@gmail.com>
On Mon, Jan 11, 2021 at 6:46 AM DENG Qingfang <dqfext@gmail.com> wrote:
> MT7530's LED controller can drive up to 15 LED/GPIOs.
>
> Add support for GPIO control and allow users to use its GPIOs by
> setting gpio-controller property in device tree.
>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Double-check the initial output conditions as indicated by
Russell, if you really want to be thorough, use an oscilloscope
but check the specs at least.
> +static u32
> +mt7530_gpio_to_bit(unsigned int offset)
> +{
> + return BIT(offset + offset / 3);
> +}
So for offset 0..14 this becomes bits
0, 1, 2, 4, 5, 6, 8, 9, 10, 12 ... 18
What is the logic in this and is it what you intend?
Please add a comment explaining what the offset is supposed
to become for offsets 0..14 and why.
> + gc->ngpio = 15;
And it really IS 15 not 16? Not that I know network equipment
very well...
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-01-18 14:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 5:44 [PATCH net-next 0/2] dsa: add MT7530 GPIO support DENG Qingfang
2021-01-11 5:44 ` [PATCH net-next 1/2] dt-bindings: net: dsa: add MT7530 GPIO controller binding DENG Qingfang
2021-01-14 19:11 ` Rob Herring
2021-01-18 14:43 ` Linus Walleij
2021-01-11 5:44 ` [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support DENG Qingfang
2021-01-11 11:04 ` Russell King - ARM Linux admin
2021-01-11 13:40 ` DENG Qingfang
2021-01-11 13:55 ` Russell King - ARM Linux admin
2021-01-18 14:55 ` Linus Walleij [this message]
2021-01-19 3:20 ` DENG Qingfang
2021-01-22 10:06 ` Linus Walleij
2021-01-11 13:43 ` [PATCH net-next 0/2] dsa: add MT7530 " Vladimir Oltean
2021-01-14 9:36 ` Bartosz Golaszewski
2021-01-11 15:46 ` Marek Behún
2021-01-12 2:50 ` DENG Qingfang
2021-01-14 17:08 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYA2fWF_1K+2aYoZnBAsm9H3=VHpeT4ZDU5sCdrOUWx=w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).