From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDE8C4741F for ; Thu, 5 Nov 2020 10:52:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 228F422228 for ; Thu, 5 Nov 2020 10:52:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d/RC4QlH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730114AbgKEKwn (ORCPT ); Thu, 5 Nov 2020 05:52:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726152AbgKEKwm (ORCPT ); Thu, 5 Nov 2020 05:52:42 -0500 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59C52C0613D2 for ; Thu, 5 Nov 2020 02:52:42 -0800 (PST) Received: by mail-lj1-x244.google.com with SMTP id d24so1070596ljg.10 for ; Thu, 05 Nov 2020 02:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IbC7h6sutytvBKVgRkW8YBm4v4oQThhwvuIz3XlFJpw=; b=d/RC4QlHsEU0Pk+87b5hebgQR1nvUbGfz+KWgyYPw8avJty+oHtYWwRBfI9ZwNnjQk 6x1f9VNEkjxS+WacQizm9QFnRFRoNTRgXz7J8hUL7gDHTr1r0B4CDTIH++hxOUWPbRHA faB9Z1G3wfURCCb570cPMFzwdpYsz5NNLR9grwb6NletLAXur80zPGuj6TnPTgqIsI6W 73tvdQLbSeHs/ZIHScGvMbbglljfvtEcmDpRr1SmCjt0Cs2115AxcxEJIltrAcsJpAIs i7f4CKXDgFTYIlx2Oia+shgKsQ9vbBqcm5RZnKYsE+6tO+5eUkPHBV9yZoGBsu8zWwxP sFlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IbC7h6sutytvBKVgRkW8YBm4v4oQThhwvuIz3XlFJpw=; b=Lv9FyIZk6lJ0U287AHTgFZY630D6BT2dz6o6j0OHHENbfTXDRWhxzshma4znEszyhc HkcfOOY1CX20eH2+WIV6vGJ9SiStCGjpiBpZNs9IT3m99MTIOi4wKB75WS6cIcYhW65X z90OFLmQ37H3UiljyboixroGdiLL3TgAIVz1Mr+d/+W0/T9JUFHoKvTwO/nypYrhbMxx SVy/k3vqaAZu1Bv1nBs7uN99Tw9acEV37MtIqXN4jni9gTW8nQjark8sVHbjZ31t4s+i j1JbXQzX/GPKb3ZIOQe3F1qlPJEsu1ycBe1oxux46TDVScIqN43K6zAA7tV/v/2Z+CZy cfZw== X-Gm-Message-State: AOAM533KxgJxmQEggHZ1fUrnA3DHq+yfXV5qULMVgvfldaRe0fEQwesd BgigQPC+SpZzp4c7AscCFbcpiYCWHR2FaioKE0ljnQ== X-Google-Smtp-Source: ABdhPJwMZsQSFYx3yHXvvtRlVkabm7C64j8LuP2+XUU2+XVFwAx/DWoa4YDvNPprZ43yAgspd5XcguY3mqI1O9Ir5Vs= X-Received: by 2002:a05:651c:1205:: with SMTP id i5mr726163lja.283.1604573560846; Thu, 05 Nov 2020 02:52:40 -0800 (PST) MIME-Version: 1.0 References: <20201027121725.24660-1-brgl@bgdev.pl> In-Reply-To: <20201027121725.24660-1-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 5 Nov 2020 11:52:30 +0100 Message-ID: Subject: Re: [PATCH 0/8] slab: provide and use krealloc_array() To: Bartosz Golaszewski Cc: Andy Shevchenko , Sumit Semwal , Gustavo Padovan , =?UTF-8?Q?Christian_K=C3=B6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , "Michael S . Tsirkin" , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , Linux Media Mailing List , "open list:DRM PANEL DRIVERS" , linaro-mm-sig@lists.linaro.org, "linux-kernel@vger.kernel.org" , linux-edac@vger.kernel.org, "open list:GPIO SUBSYSTEM" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev , Linux Memory Management List , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 27, 2020 at 1:17 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Andy brought to my attention the fact that users allocating an array of > equally sized elements should check if the size multiplication doesn't > overflow. This is why we have helpers like kmalloc_array(). > > However we don't have krealloc_array() equivalent and there are many > users who do their own multiplication when calling krealloc() for arrays. > > This series provides krealloc_array() and uses it in a couple places. > > A separate series will follow adding devm_krealloc_array() which is > needed in the xilinx adc driver. The series: Acked-by: Linus Walleij I really like this. Yours, Linus Walleij