From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7522C433DB for ; Fri, 22 Jan 2021 10:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FB94239EF for ; Fri, 22 Jan 2021 10:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbhAVKK1 (ORCPT ); Fri, 22 Jan 2021 05:10:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727815AbhAVKH1 (ORCPT ); Fri, 22 Jan 2021 05:07:27 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECB4C061786 for ; Fri, 22 Jan 2021 02:06:43 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id v24so6747891lfr.7 for ; Fri, 22 Jan 2021 02:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=53LZGt+p3UglMmJ8LC7owG+jDtMJhUwB3mc3c22vo3w=; b=yh/tASQseJelhwA8jiNe7G+W3KDRWW1njEvuW/XSR6hWhLACFO+3sS7ZPZgJ9aST0v oFk/pn/i82nx2thugENYmvvL3JfDvOlhHldDiLx+runOC2sJlqzLL9M6NpJvY6PV1pcG OgpdD/gayiEOFeOg1e6OJxfd/6GJOOgFxOr68V7TeyWGKerpb/HV/1qyQ9LYPNLPv1+z hlWzdt0d0bo4bmizD9krbFveuKWYj0dlkBhxBoucYfvdsWW8jV/8zj/FYyUbfLRBhpJ6 NgC3ooDGAJiOCtisAeBgSmc0XoZ4oEoOF+SVNjhNdQJd6dAEWnj817BaPGSwMmQ2JGR9 OYbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=53LZGt+p3UglMmJ8LC7owG+jDtMJhUwB3mc3c22vo3w=; b=ETb2L60O1TW1VfAOxFUg7hFOLY5HRneMyQBz/fabIpjzXLlSTfx+Y8fQ3diUsSI1u1 J9s5DPZLWZLcawAU7kaIKAgZ+80k2mJaKESWQM3mpCwAcMwlyTYpXbzTvuUEqsjyyLwB /4R5G5Eyw2MwyCEF6yEQcm5f6dgVWIyjPH4X1b6uGJlkomQga+LqfG3o5FjwrZ5O8LbN 4RUcNmngyajdSGoLf9+p6JMwoeJUgPuB9tTKIfpU+oedRxhNM2SSRnSSaX6I2Rt+b07Q RdMd2SQ7PumdxEulfrFIOiSyiRAaXMfDSdd4Aq4RMo2jjMXZS+ZoiiHIyeEExJB3nutR vx6A== X-Gm-Message-State: AOAM5301KSlqS379y5tg3eNIm1YSPMZuqiheOfI6F4xDmAP2KQo+ptc+ I8tejUv0E6J3jE87WvVoLgtdYQi/nZ/XydQQegSelg== X-Google-Smtp-Source: ABdhPJyoTle4qxXu3NBqEJlHwN6jTzoBM52s7nfkB0Kj/1T93Ni/LPtdYQD6ZORaUqNYGsjXZQISQSEyffbqb3DhuEk= X-Received: by 2002:ac2:5c45:: with SMTP id s5mr32690lfp.586.1611310001970; Fri, 22 Jan 2021 02:06:41 -0800 (PST) MIME-Version: 1.0 References: <20210111054428.3273-1-dqfext@gmail.com> <20210111054428.3273-3-dqfext@gmail.com> In-Reply-To: From: Linus Walleij Date: Fri, 22 Jan 2021 11:06:30 +0100 Message-ID: Subject: Re: [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support To: DENG Qingfang Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Rob Herring , Matthias Brugger , Sean Wang , Landen Chao , Philipp Zabel , Russell King , netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "moderated list:ARM/Mediatek SoC support" , "linux-kernel@vger.kernel.org" , =?UTF-8?Q?Ren=C3=A9_van_Dorst?= , Frank Wunderlich Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 19, 2021 at 4:20 AM DENG Qingfang wrote: > On Mon, Jan 18, 2021 at 10:55 PM Linus Walleij wrote: > > > > So for offset 0..14 this becomes bits > > 0, 1, 2, 4, 5, 6, 8, 9, 10, 12 ... 18 > > > > What is the logic in this and is it what you intend? > > Yes. Bit 0..2 are phy 0's LED 0..2, bit 4..6 are phy 1's LED 0..2, etc. OK add a comment and explain how the bits relate to each PHY and how the lines are arranged per-phy so it is crystal clear for people reading the driver. Thanks! Linus Walleij