From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C7BC4320E for ; Wed, 11 Aug 2021 13:24:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BDFC6054F for ; Wed, 11 Aug 2021 13:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbhHKNYW (ORCPT ); Wed, 11 Aug 2021 09:24:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbhHKNYL (ORCPT ); Wed, 11 Aug 2021 09:24:11 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5532AC06179F for ; Wed, 11 Aug 2021 06:23:37 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id p38so5833294lfa.0 for ; Wed, 11 Aug 2021 06:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G1DS3dhDnQ4urDmNfj/USqiCFClTi+Z5dRNYG0dYe2E=; b=NChTj9NxKFObAclXn2BntB3aw+Vd0IDfRn7Dvu3PGrTC8DEKz5eBR6UJ/LdvBm55ZX NlYb/Up9TurVBBTwJ3jC1OjeOfZ7fHVLoxd0OXcA0p1zrytca8apsPvlZxjnfkNXqa8O o9PBGGgPC4SAuYxiAfWzybxgwYUhUpb62FRnnagJ5uFhODDmQiQ5X7b9sPaGPKoormtt XhSr4UIPjO0iUgierg6TBTiHqQortcyJHfP0fvYMDXSlz41oXgdsgZi5PgEGaM9e1GQl U9sCNMpacMUXW4q6L7+mXu1kX5Pyom/75OtpDHsQN1erGp5QCi89SJ3pSbWJjUU9/m1Z C2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G1DS3dhDnQ4urDmNfj/USqiCFClTi+Z5dRNYG0dYe2E=; b=n+QW0zWgkKEPgD8p1XRdMjstOzKV3lrMvjyKn4TgUFQosam1GbiZvwBZhkuWX0vDnO 0a5yV12sykWKdjyX3UjFhYezQHL0azOPov1ZvSQcN0kiNkCs7VDwJMMIRXga4AimpwX4 bPM06JBO24+iJtbh07SUuvatC3kyzJYgWbltRv9sskCywH3jCGREbrMg4SPWTPLDph1X Mmyy/4TLqDtzrfQBotiZ2VXkSHAiGWmM/klOCGNGgaeTQbPQT4vy9jillQJIfoik2NFH z4p9O2EDtKWuxOhinvUTC2eZNSuooRVDcfkw7DEgqTMdtRYAIqDNNDTKOkM3ThpS9GgE cuUQ== X-Gm-Message-State: AOAM531NtFRdjJNcX8Cw636AxHTgJpfiJXKV8HPL85xd0xUkPxLhU5c8 wufQ/mwA0u8Ruwqhhi43AhokAJBN4B6hzDidAkYJeQ== X-Google-Smtp-Source: ABdhPJwWpOc+d0W3TyHMjyV5Kph+JZTz5Jpkx4yqIwZ8hoblgm4D3kS4sVUrpfWLOjpOX17ADZ4iXbTCSx9iVp3Tpsc= X-Received: by 2002:a05:6512:1084:: with SMTP id j4mr26289074lfg.586.1628688215624; Wed, 11 Aug 2021 06:23:35 -0700 (PDT) MIME-Version: 1.0 References: <20210809115722.351383-1-vladimir.oltean@nxp.com> <20210809115722.351383-2-vladimir.oltean@nxp.com> In-Reply-To: <20210809115722.351383-2-vladimir.oltean@nxp.com> From: Linus Walleij Date: Wed, 11 Aug 2021 15:23:24 +0200 Message-ID: Subject: Re: [RFC PATCH net-next 1/4] net: dsa: create a helper that strips EtherType DSA headers on RX To: Vladimir Oltean Cc: netdev , Jakub Kicinski , "David S. Miller" , Andrew Lunn , Florian Fainelli , Vivien Didelot , Vladimir Oltean , DENG Qingfang , John Crispin , Sean Wang , Landen Chao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 9, 2021 at 1:57 PM Vladimir Oltean wrote: > All header taggers open-code a memmove that is fairly not all that > obvious, and we can hide the details behind a helper function, since the > only thing specific to the driver is the length of the header tag. > > Signed-off-by: Vladimir Oltean Reviewed-by: Linus Walleij yours, Linus Walleij