From: Linus Walleij <linus.walleij@linaro.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Mauri Sandberg <sandberg@mailfence.com>
Subject: Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag
Date: Mon, 1 Mar 2021 14:06:42 +0100 [thread overview]
Message-ID: <CACRpkda62pL0a0Oz5VDBWsA4QBPHnYKNEputNCY-xfbSugKAAQ@mail.gmail.com> (raw)
In-Reply-To: <CALW65jbFu6apesQrdNiCSZPC2ziVOHBgjoGJi5NTgkZrD0Qv5A@mail.gmail.com>
On Sun, Feb 28, 2021 at 12:32 PM DENG Qingfang <dqfext@gmail.com> wrote:
> On Sun, Feb 28, 2021 at 7:47 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > I names the previous protocol "RTL4 A" after a 4-byte tag
> > with protocol indicted as "A", what about naming this
> > "RTL2 9" in the same vein? It will be good if some other
> > switch is using the same protocol. (If any...)
>
> RTL8306 uses 0x9 too, but the tag format is different...
Oh what a mess. :O
OK go with this. Maybe I should rename my tagger to
tag_rtl8366rb.c instead...
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-03-01 13:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 6:21 [RFC net-next 0/2] DSA driver for Realtek RTL8366S/SR DENG Qingfang
2021-02-17 6:21 ` [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag DENG Qingfang
2021-02-17 7:07 ` Heiner Kallweit
2021-02-17 11:01 ` Linus Walleij
2021-02-17 11:28 ` Heiner Kallweit
2021-02-17 10:55 ` Linus Walleij
2021-02-17 12:28 ` DENG Qingfang
2021-02-27 23:47 ` Linus Walleij
2021-02-28 11:32 ` DENG Qingfang
2021-03-01 13:06 ` Linus Walleij [this message]
2021-02-17 6:21 ` [RFC net-next 2/2] net: dsa: add Realtek RTL8366S switch driver DENG Qingfang
2021-02-17 11:12 ` Linus Walleij
2021-02-17 12:45 ` DENG Qingfang
2021-02-17 12:25 ` Vladimir Oltean
2021-02-17 15:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda62pL0a0Oz5VDBWsA4QBPHnYKNEputNCY-xfbSugKAAQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sandberg@mailfence.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).