From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91625C4727F for ; Wed, 30 Sep 2020 08:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A091206C9 for ; Wed, 30 Sep 2020 08:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gjL5GpfG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728470AbgI3Igr (ORCPT ); Wed, 30 Sep 2020 04:36:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbgI3Igr (ORCPT ); Wed, 30 Sep 2020 04:36:47 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CCA9C061755 for ; Wed, 30 Sep 2020 01:36:45 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id q8so1123624lfb.6 for ; Wed, 30 Sep 2020 01:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9vuufweZXiK+qtweKn+JmanIrM/v4NSWuNX4kYeFeDE=; b=gjL5GpfGKPcFqFwM2lUIf672Yc7U/+j1/lbLm42+rzPcjqxGiEXxdAkubv3gPImGzh HgFXBL47Fip59qWJxyAz0ZX5ywnhGP2UnSXVKnYkkONZqWgFJNk2J4V1Ihhgoswj0Sjj Qqj0EMg1SrqOFtS34srCXm7VZyzmrkeGsQAlEViXIARV5awWKZI3fCjV9QN9gQ9eZGXJ rzfTQNL2nbyc8o8Otuy7rM6Xgm3XK4yhuBuT84bLKjiJijWrQRFhpiJ2zFO5MAxyAMae B6FaqSD2w80kSvAYW8fz8IcArWIGpoZC2nil6cIErgk7XyoL9Df8/CClsRLHGN23tjvG d8cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9vuufweZXiK+qtweKn+JmanIrM/v4NSWuNX4kYeFeDE=; b=tbx+pQjp8aN8buqWw2kEnnBwHOYHO+Lr0sAL0JnatxRh3QpgXstyzQEr5eG95vciEc pHVl3u8q4Nk/3BKM3/j9F/S61UJEDKnpdwAVz2xINNuP4AOxgpEKIuK01CIUxkMGZSEO yRb2PPjVAcOiDvkec4bFDThbD0BpVckD/0jgfeuEsg7avbiBzHk4Aq4+JkOXB0EIBMt4 XK59eq9beoO+mBYOhtSk8xuzWJ5OzHsUZ5SzsxHenEHNGglvwGrx4/jfjvTQWG3VXCXD 6sEVb2pRhP8vnISoakJ++fYHLGCd0x8VIw/A3kX8n6nWVGVBKghlKnAUpB4E9yq1gp6H BRJA== X-Gm-Message-State: AOAM530FNf8jjKv5I4xNhHfVVOBC7sj3cZpp1KuDLmPyOJY9Mg8WPqB0 OtirVzvUJJFwxYSHJaf9h7/TKFdQOtL4d5BCmKXWIA== X-Google-Smtp-Source: ABdhPJzaWUnGCbvSENiFo0JJeu13V0FObTX94fq/SaKDPcgBN2oIp2Vt1LzUExTKO8/zNsbsxHp2ab9V0eXYgwlwsWI= X-Received: by 2002:a19:1c8:: with SMTP id 191mr464983lfb.585.1601455002449; Wed, 30 Sep 2020 01:36:42 -0700 (PDT) MIME-Version: 1.0 References: <20200926193215.1405730-1-vladimir.oltean@nxp.com> <20200926193215.1405730-16-vladimir.oltean@nxp.com> In-Reply-To: <20200926193215.1405730-16-vladimir.oltean@nxp.com> From: Linus Walleij Date: Wed, 30 Sep 2020 10:36:31 +0200 Message-ID: Subject: Re: [PATCH v3 net-next 15/15] net: dsa: tag_rtl4_a: use the generic flow dissector procedure To: Vladimir Oltean Cc: netdev , "David S. Miller" , Andrew Lunn , Florian Fainelli , Vivien Didelot , Jakub Kicinski , DENG Qingfang , Mauri Sandberg Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Sep 26, 2020 at 9:33 PM Vladimir Oltean wrote: > Remove the .flow_dissect procedure, so the flow dissector will call the > generic variant which works for this tagging protocol. > > Cc: Linus Walleij > Cc: DENG Qingfang > Cc: Mauri Sandberg > Signed-off-by: Vladimir Oltean > --- > Changes in v3: > Remove the .flow_dissect callback altogether. > Actually copy the people from cc to the patch. That's a neat refactoring! Reviewed-by: Linus Walleij Yours, Linus Walleij