From mboxrd@z Thu Jan  1 00:00:00 1970
From: Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH net-next 2/2] tcp: do not aggressively quick ack after ECN events
Date: Tue, 22 May 2018 10:04:28 -0400
Message-ID: <CACSApvYiF90axDXAKk7_z5LmfbvxORPR282Ltxj+sRAHWLy6xg@mail.gmail.com>
References: <20180521220857.229273-1-edumazet@google.com> <20180521220857.229273-3-edumazet@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, Van Jacobson <vanj@google.com>,
        Neal Cardwell <ncardwell@google.com>,
        Yuchung Cheng <ycheng@google.com>,
        Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f194.google.com ([209.85.223.194]:38978 "EHLO
        mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751311AbeEVOFK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 22 May 2018 10:05:10 -0400
Received: by mail-io0-f194.google.com with SMTP id r9-v6so18607851iod.6
        for <netdev@vger.kernel.org>; Tue, 22 May 2018 07:05:10 -0700 (PDT)
In-Reply-To: <20180521220857.229273-3-edumazet@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, May 21, 2018 at 6:08 PM, Eric Dumazet <edumazet@google.com> wrote:
> ECN signals currently forces TCP to enter quickack mode for
> up to 16 (TCP_MAX_QUICKACKS) following incoming packets.
>
> We believe this is not needed, and only sending one immediate ack
> for the current packet should be enough.
>
> This should reduce the extra load noticed in DCTCP environments,
> after congestion events.
>
> This is part 2 of our effort to reduce pure ACK packets.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Acked-by: Soheil Hassas Yeganeh <soheil@google.com>

Thanks for the patch!