From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B524EC38142 for ; Fri, 27 Jan 2023 22:08:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232618AbjA0WIj (ORCPT ); Fri, 27 Jan 2023 17:08:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232504AbjA0WIh (ORCPT ); Fri, 27 Jan 2023 17:08:37 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BA4F7F698 for ; Fri, 27 Jan 2023 14:08:36 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id b127so2447289iof.8 for ; Fri, 27 Jan 2023 14:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=al9oy3E79ODPhEjXEHhJKk/A8XmQzAwjko7z1WJnZkc=; b=NPwfv5aXAsscvOxtwXtO9484xYSoDmyOBMRHaq6lKLS61CV1IWSbgh14Mvd5VHqR4X bwh/qNckPyHJ3rRfcMqtRB0SQKEsB2IPGnJT/H4kwO7OemTtVM4iRqS2UZSsGlDbjn/Y nkENSjnV/+noRbM4zBn6bygihOczkHMzXE/os= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=al9oy3E79ODPhEjXEHhJKk/A8XmQzAwjko7z1WJnZkc=; b=ZAbU2m3hIrDZr930n+moocAH9mUtBQxRBos1aSudJvTKhyWi0m5T3Acim1N46vBRx4 fdLgRkRkfMWzFf2yfbme6hu0SVTmmcjfdLF+lsdvdnSVnaqotF8GwQGeXM8JC0teoojS 95kfOOkA+f0fIkD9ooFPA/qL235CQYB3BL3EgaVSmrPKABV6jXRUZskDug0Ch9a5YGza eS8TiI3bmsLgcltZU/H8N2Sw15ViKd8t/wmi3u+Uh4qyf4Xn6ZUzUnCSGWIgKzuBw/VR B5gVq4o5OcF8l/v+WlqLAvEYhM36M6JlS1EabQwzzx7pskVzDEZ5NNPtNdDpI/HvVODJ Hmpw== X-Gm-Message-State: AO0yUKW4RKYSC8Z1vDIXU93mihq6y9uRHwaLzLtmRG9DpohhKeykc0M1 5GeNzEF4AaLIv0BWjHcDMaE4QtfWP7AYAz06a8C7dw== X-Google-Smtp-Source: AK7set/q2kaa+ypIxOjsL1soOvTsxLlm1mLlh4dFrILigvfOQioehJJTu0K8nJ8YHs49B/9ZVlPODT+AvZNEaOu5JHQ= X-Received: by 2002:a05:6638:10d4:b0:3a9:6f3a:4b55 with SMTP id q20-20020a05663810d400b003a96f3a4b55mr805907jad.6.1674857315411; Fri, 27 Jan 2023 14:08:35 -0800 (PST) MIME-Version: 1.0 References: <20221220075215.1.Ic12e347e0d61a618124b742614e82bbd5d770173@changeid> <56d4941a-ad35-37ca-48ca-5f1bf7a86d25@quicinc.com> <87tu0wcb3l.fsf@kernel.org> In-Reply-To: <87tu0wcb3l.fsf@kernel.org> From: Abhishek Kumar Date: Fri, 27 Jan 2023 14:08:23 -0800 Message-ID: Subject: Re: [PATCH] ath10k: snoc: enable threaded napi on WCN3990 To: Kalle Valo Cc: Manikanta Pubbisetty , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thanks for all the comments. I will call dev_set_threaded() directly without HW params and rollout a v2 soon. On Thu, Jan 12, 2023 at 2:15 AM Kalle Valo wrote: > > Abhishek Kumar writes: > > >> > --- a/drivers/net/wireless/ath/ath10k/snoc.c > >> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > >> > @@ -927,6 +927,9 @@ static int ath10k_snoc_hif_start(struct ath10k *ar) > >> > > >> > bitmap_clear(ar_snoc->pending_ce_irqs, 0, CE_COUNT_MAX); > >> > > >> > + if (ar->hw_params.enable_threaded_napi) > >> > + dev_set_threaded(&ar->napi_dev, true); > >> > + > >> > >> Since this is done in the API specific to WCN3990, we do not need > >> hw_param for this. > > > > Just so that I am clear, are you suggesting to enable this by default > > in snoc.c, similar to what you did in > > > > https://lore.kernel.org/all/20220905071805.31625-2-quic_mpubbise@quicinc.com/ > > > > If my understanding is correct and there is no objection, I can remove > > hw_param and enable it by default on snoc.c . I used hw_param because, > > as I see it, threaded NAPI can have some adverse effect on the cache > > utilization and power. > > WCN3990 is the only device using SNOC bus so the hw_param is not needed. > It's safe to call dev_set_threaded() in ath10k_snoc_hif_start() > unconditionally as it only affects WCN3990. > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches